I've committed and pushed changes to MDL that should make it compile. I don't think it will work - I'll be doing that next but I wanted to get the project to compile.
Basically, all of the List-like MDL classes now extends Group rather than ContainerBase, which I should delete. Then I needed to make the classes implement the updates to IItemRendererParent. The DataGroup isn't used any longer so those classes have to act as ItemRendererParents now. Probably a better way is to use a proxy and consolidate the code; I used this for Panel. But I will get MDL to work without major structural changes since it JS-side only which makes it easier now. —peter On 3/23/17, 2:01 PM, "Peter Ent" <p...@adobe.com> wrote: >Yes, Chris does have a good point and from now on* I will definitely use >feature branches. I thought I could squeeze this through. > >I checked in changes to Chart that should make it compile. I doubt it will >run, but that is on the list. I will look into MDL now. That will take >longer. > >I am leary about doing the rollback at this point. You should be able to >remove MDL from the build temporarily. If you are relying on it, I will >try to be as quick as possible and test against the MDL example before >pushing my changes. > >* I will use feature branches once I get MDL working. > >Apologies, >‹peter > >On 3/23/17, 1:31 PM, "Harbs" <harbs.li...@gmail.com> wrote: > >>Sure. Including me. >> >>But Chris does have a point that we should be using feature branches more >>than we are. >> >>The tone of my question might have not come across correctly. I meant to >>ask how difficult it would be to move all changes to a feature branch and >>push the feature branch. If it¹s too difficult, we can just continue to >>fix the develop branch for now. >> >>> On Mar 23, 2017, at 7:19 PM, Josh Tynjala <joshtynj...@gmail.com> >>>wrote: >>> >>> Peter warned the list that his changes would break some things >>>temporarily, >>> and he asked if he should proceed. Everyone who responded said that it >>>was >>> okay. >>> >>> - Josh >>> >>> On Thu, Mar 23, 2017 at 10:11 AM, Harbs <harbs.li...@gmail.com> wrote: >>> >>>> Very good question. >>>> >>>> Peter, is there any chance to roll back containers and layouts and >>>>move >>>> all the changes to a feature branch until things are stable? >>>> >>>>> On Mar 23, 2017, at 7:58 AM, Christofer Dutz >>>>><christofer.d...@c-ware.de> >>>> wrote: >>>>> >>>>> Why don't you guys use feature branches? >>>> >>>> >> >
