Sounds good. Thanks. -Alex
On 3/28/17, 12:58 PM, "Greg Dove" <greg.d...@gmail.com> wrote: >Thanks, this was used in a local Log utility which is used for indirect >prefixing with info/warn etc. iirc I could not simply use trace >cross-platform for this approach, I think there were problems with >trace.apply for js (I would need to check, but this is what I recall) so I >ended up referencing console.log directly for js > >I changed console.log to window.console.log and that still gave 'No >GoogDep for window' >I think this use should be rare and trace will normally be used, so I >added >'window' to NativeUtils and all was well. So I will commit this change. > > > >On Wed, Mar 29, 2017 at 8:21 AM, Alex Harui <aha...@adobe.com> wrote: > >> >> >> On 3/28/17, 12:12 PM, "Greg Dove" <greg.d...@gmail.com> wrote: >> >> > >> >FWIW I tried with remove-circulars again but that broke on 'No GoogDep >>for >> >console' this time, but I guess you are still working on this. >> >> Actually, I would prefer that folks who hit "No GoogDep" fix it >>themselves >> by adding what they need to NativeUtils.java. Although for console, I >> think you could also use "window.console". >> >> Thanks, >> -Alex >> >>
