As far as I understood it, right now debug is the only option as all working on
larger applications can’t use the release build.
I think trace statements should eventually be wrapped by a “DEBUG” define to
allow including them and have them excluded by default.
We are talking about efficiency of produced code … for me the traces are an
equally anti-pattern as are the System.out.printline statelents in the Compiler.
I wouldn’t call it a blocker for the next release, but definitely one for 1.0.0
Chris
Am 23.05.17, 16:55 schrieb "Alex Harui" <aha...@adobe.com.INVALID>:
Interesting topic. Is this something that folks think is important for
this release?
I would not want to have a "no trace statements" policy. IMO trace
statements are a useful tool when used appropriately. As long as the tool
chain can remove trace statements in production code, that should be all
we need. But I think it is too late to be dealing with this for this
release.
I use trace statements when I'm not sure about some code condition and
when there is some tricky thing that can be debugged by examining a log of
output. Throwing an exception stops execution and it cannot be easily
restarted. A trace statement says "hey, I think the code didn't expect
this condition" but allows execution to continue.
The only "rule" we had in regular Flex was that trace statements should
pollute your output with tons of stuff. The checkintests checked for
unexpected trace output in the main code paths of the components. Many
trace statements were commented out or behind logic that kept them off
until you needed them.
My 2 cents,
-Alex
On 5/23/17, 1:46 AM, "Justin Mclean" <jus...@classsoftware.com> wrote:
>Hi,
>
>I’ve noticed in a few places there are some unnecessary trace statements
>in the SDK. Like for instance here [1].
>
>I’m thinking we probably shouldn’t have trace statements in production
>code. Sonar cube flags it as an issue. [2] Anyone think otherwise?
>
>On the JS side these are only omitted when goog.DEBUG is defined but
>still be a little expensive at it calls slice before doing that.
>
>Thanks,
>Justin
>
>1.
>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co
>m%2Fapache%2Fflex-asjs%2Fblob%2Ffd709d137e5f740fd3a7f7dfbcde0e898e25f103%2
>Fframeworks%2Fprojects%2FDragDrop%2Fsrc%2Fmain%2Fflex%2Forg%2Fapache%2Ffle
>x%2Fhtml%2Fbeads%2Fcontrollers%2FDragMouseController.as&data=02%7C01%7C%7C
>2d1d49dd9de4462348e108d4a1b847e6%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C
>0%7C636311260235128408&sdata=mpAT3eCx2Cz1IUSRA8M07s2oW4xo%2BpqIm0Jliu%2BkQ
>24%3D&reserved=0
>2.
>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbuilds.ap
>ache.org%2Fanalysis%2Fcomponent_issues%2Findex%3Fid%3Dorg.apache.flex.flex
>js.framework%253Aflexjs-framework-parent%23resolved%3Dfalse%7Cseverities%3
>DCRITICAL%7Crules%3Dflex%253AS1951&data=02%7C01%7C%7C2d1d49dd9de4462348e10
>8d4a1b847e6%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63631126023512840
>8&sdata=agE57nLohxBpNqBMz9pVKKNTOeB6qRxWnu%2FMBM4bpaw%3D&reserved=0
