Alex, fyi if I delete the target directory inside flex-typedefs (to be sure
it is 'clean', although I am quite sure mvn clean does this also) , then
run mvn clean compile, i get the following in svg.js inside downloads:
/**
* @param {string} type
* @param {!EventListener|(function(!Event): (boolean|undefined))| null}
listener
* @param {boolean=} opt_useCapture
*/
SVGElementInstance.prototype.addEventListener = function(type, listener,
opt_useCapture){};
so for me at least, it does already seem to have the "(function(!Event):"
etc in it.
On Thu, Jun 15, 2017 at 11:09 AM, Alex Harui <[email protected]>
wrote:
> I just ran the curl command (sorry if my Outlook has munged the URL). I
> got the same hash. When I open it up, I see:
>
> /**
> * @param {string} type
> * @param {!EventListener|(function(Event): (boolean|undefined))| null}
> listener
> * @param {boolean=} opt_useCapture
> */
> SVGElementInstance.prototype.addEventListener = function(type, listener,
> opt_useCapture){};
>
> The patch is trying to replace
>
> (function(Event):
>
>
> With:
>
> (function(!Event):
>
>
> I verified locally that both my Ant and Maven builds from the repos can
> successfully download and patch svg.js. I did a clean before each build
> to verify that svg.js was not in the repo working copy folders.
>
>
> So you are saying that when you use curl to grab that file it already has
> "(function(!Event):" in it? That isn't the case for me. That is really
> strange given the hash was the same.
>
> Very puzzled,
> -Alex
>
>
> On 6/13/17, 7:23 PM, "Justin Mclean" <[email protected]> wrote:
>
> >Hi,
> >
> >Changing to -1 (binding).
> >
> >I can confirm the tyoedef issue is not due to differences in git version.
> >
> >My guess (but not confirmed) is that some people may to have the js file
> >file cached and that it has changed recently so the patch no longer
> >applies.
> >
> >I can confirm that the current js.patch will not apply to the file
> >current file here [1].
> >
> >Can some mind doing a diff with their version of the file and the version
> >here [1]?
> >
> >Or posting a hash of the file they have:
> >$curl
> >https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fstorage.g
> >oogleapis.com%2Fgoogle-code-archive-downloads%2Fv2%2Fcode.google.com
> %2Fclo
> >sureidl%2Fsvg.js&data=02%7C01%7C%7C2663b54b26d74c4e011c08d4b2cc
> 5b6c%7Cfa7b
> >1b5a7b34438794aed2c178decee1%7C0%7C0%7C636330038163199802&
> sdata=GzJiK3o9QT
> >3TcUiBFDUpKJIYELPlBIWbKHVsuIeIzxs%3D&reserved=0 > svg.js
> > % Total % Received % Xferd Average Speed Time Time Time
> >Current
> > Dload Upload Total Spent Left
> >Speed
> >100 155k 100 155k 0 0 74173 0 0:00:02 0:00:02 --:--:--
> >74189
> >$md5 svg.js
> >MD5 (svg.js) = 568eb2c11ba33da58eb0471beef76cb9
> >
> >Thanks,
> >Justin
> >
> >1.
> >https://na01.safelinks.protection.outlook.com/?url=
> https%3A%2F%2Fstorage.g
> >oogleapis.com%2Fgoogle-code-archive-downloads%2Fv2%2Fcode.google.com
> %2Fclo
> >sureidl%2Fsvg.js&data=02%7C01%7C%7C2663b54b26d74c4e011c08d4b2cc
> 5b6c%7Cfa7b
> >1b5a7b34438794aed2c178decee1%7C0%7C0%7C636330038163199802&
> sdata=GzJiK3o9QT
> >3TcUiBFDUpKJIYELPlBIWbKHVsuIeIzxs%3D&reserved=0
> >
>
>
