Hi, > You willy-nilly changed equality to strict equality. That cost me time and > money. I vetoed your change. Period.
I have no issue with you fixing a bug or even asking me to fix it but please put my changes back. > Changing all equality to strict equality is (IMO) pedantic. In most cases the > two operators are functionally equivalent. In some cases strict equality is > necessary. In some cases equality is necessary. It gives a significant performance increase, by making changes like this in a few places in a a real world application I got performance gains of 30-40%. There is wide consensus that the evil twins == and != are unsafe to use and can cause all softs of issues. Code quality tools like list and sonar cube also flag these as issues. > Performance gains are NOT significant. Performance gains by using strict > equality is in microseconds (at most). Please read the previous threads on dev about this or do your own tests. > If you end up doing a type conversion to use the strict equality, all > performance gains are lost. This topic has been discussed to death on other > places on the web. Strict equality comes at a cost of an extra byte in the > download No it doesn’t again you are forgetting the closure compiler optimises things for us here and in the tests I’ve done so far there was no size increase and in fact a size decrease. Thanks, Justin
