Thanks for working on this.
> -TLFEditTestFlexJS result is broken in JS (I see missing dependencies - is
> this is compiler problem?)
It needed -remove-circulars. I just fixed that.
> On Aug 22, 2017, at 2:56 AM, Greg Dove <greg.d...@gmail.com> wrote:
>
> I just made some changes in manual tests, including updates to the ant
> scripts to be more consistent with the ant scripts in the regular examples.
> I fixed a couple of issues in the GenericTests and renamed it to UnitTests
> and also added a maven build for that project. It should be easy to add
> maven to other manual tests if required and set ant build to be compatible
> with maven. This might make it easier for others to join in because maven
> setup seems a bit easier than ant (in terms of all the env vars).
>
> I'd like to suggest a bit of a cleanup in here though.
>
> Here's a bit of a status report:
>
> 1. General observations:
> I do see some mouse event coercion issues in swf in some examples
> (exceptions thrown in debug player). Did not investigate further.
>
> DatabindingTestbed has a broken constant binding in swf build. Fix required
> is most likely required in compiler BindingInfo:
> Details:
> org.apache.flex.compiler.internal.codegen.databinding.BindingInfo
>
> line 504:
> sourceString = leftDef.getBaseName() + "." + def.getBaseName();
> isSimplePublicProperty = true;
>
> The above works for as-is for js, but not for swf in the case of leftDef
> being a ClassDefinition (I think)
>
> e.g. something like <Label text="{StaticHost.STATIC_CONST}" />
>
> covering this case with isSimplePublicProperty = false in BindingInfo will
> fix it, but this could also likely be optimized.
>
> 2. I made some quick fixes in some of the tests:
> -EffectsExample- added back the Effects timer
>
> -FlexJSTest_SVG - changed some namespaces and gave Container width and
> height (to avoid clipping at zero width and height).
>
> -FormExample - gave Container for form inputs explicit height to avoid
> clipping at zero height in js.
>
> -ImageTest - fixed 'src' attribute for Image
>
> -ListsTest - fixed 'src' property for Image in ProductItemRenderer
>
> 3. The following tests need review (and possible removal if they are no
> longer needed?):
> -DataGridXcompile build completely broken
> -FlexJSTest_createjs broken (swf build)
> -FlexJSTest_HTML5 broken (swf build)
> -FormatExample build completely broken
> -TLFEditTestFlexJS result is broken in JS (I see missing dependencies - is
> this is compiler problem?)
> -VanillaSDK_POC - based on the ant script, this seems obsolete and could
> probably be removed?
