I updated and ran the approval script. It found some tests without headers. I added headers and kicked off a new nightly build. Looks like it takes a couple of hours to build on my slow Azure VM. Other than that and the license thing Justin found, I think it is ok to release.
-Alex On 11/3/17, 7:34 PM, "Piotr Zarzycki" <piotrzarzyck...@gmail.com> wrote: >Cool! License has been added. > >Thanks, >Piotr > >On Sat, Nov 4, 2017, 03:14 Justin Mclean <jus...@classsoftware.com> wrote: > >> Hi, >> >> > Is it not enough if that file has header with those license >>information ? >> >> It’s enough to satisfy the MIT license conditions but not quite enough >>for >> ASF policy. [1] Adding it to LICENSE also make it clear to any users >>that >> their’s MIT licensed software included without them looking for it / >> accidentally coming across it. >> >> Thanks, >> Justin >> >> 1. >>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.apach >>e.org%2Fdev%2Flicensing-howto.html%23permissive-deps&data=02%7C01%7C%7C22 >>af1e8362cd4fea10ce08d5232ca106%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0 >>%7C636453596969259739&sdata=h2na%2Boz6K6HlgyYHWJhQcDicw9URDGyOV4BrejO2z8E >>%3D&reserved=0
