On Tue, Nov 14, 2017 at 7:50 PM, Par Niclas Hedhman <nic...@apache.org> wrote:
> > Alex, > it is called "Open SOURCE" and not "Binary with link to Source" for a > reason. Apache Software Foundation official only promise SOURCE releases. > Any convenience binaries are not required/expected. It is not kosher to so > called release (or make available) any binaries that are not built from an > official source releases and place them in /dist. That goes against policy > and infrastructure is likely going to have a strong opinion on the matter, > i.e. pull the artifacts if found out. > > Very simple workflow; > 1. Get your Source Release in order. > 2. Check it and vote > 3. Release it to /dist > 4. Worry about anything else... > > Point 4 includes things like "Build binary convenience artifacts from the > Source release". > Niclas, Apologies if I have missed some context. Piotr is the release manager here, I am not sure why your email is directed towards Alex? Quoting Alex: "But given they don't look right in US Windows systems, unless there is an easy workaround, it might be a good idea to fix this issue in another RC." As you can see in this thread, we are trying to figure out where the source package gets messed up and we are trying to fix it. While your input is appreciated, I think your tone is a bit confrontational. Thanks, Om > > HTH > Niclas > > On 2017-11-14 14:43, Alex Harui <aha...@adobe.com.INVALID> wrote: > > I think I just verified that the binary artifacts are ok regarding the > > non-ascii characters. I think that's because they are correct in the > > repo, and were compiled into bundles from that repo source. I'm not sure > > when the files get screwed up. I think it is when Ant copies the files > to > > the temp folder to be packaged. Also, I'm not clear what code page they > > are actually in. I tried using "iconv" on my Mac to convert the files, > > but I couldn't find the right source page. > > > > I also ran installer.xml in the binary artifact and found that the > scripts > > aren't executable. I looked in the build.xml and installer.xml and do > not > > see any calls to chmod that would fix that, like there is in the FlexJS > > versions of those files. There are some indications from the archives > > that this also has been a problem for as far back as 4.12. > > > > So, my assessment is: > > 1) the binary artifacts are ok. No new problems. > > 2) the source artifacts are not ok. There might be a workaround if we > can > > figure out how to convert the code page on those files. > > 3) Would be nice to fix the executable bit on the scripts, but not a new > > problem either. > > > > So, the vast majority of our users may not hit this problem since they > > consume the binary artifacts and not the source artifacts. I'll leave it > > up to Piotr as to whether he wants to roll another RC that picks up > > changes. To fix the executable bits, I would recommend looking at how > > chmod was used in the FlexJS build.xml and installer.xml. > > > > My 2 cents, > > -Alex > > > > On 11/13/17, 10:19 PM, "Piotr Zarzycki" <piotrzarzyck...@gmail.com> > wrote: > > > > >Hi Justin, > > > > > >Could you please post screenshot what is wrong cause I don't > understand. - > > >I wanted to compare results of tests between those two RCs. > > >I will cut another RC, but not because of the issue above, but because I > > >couldn't run sh script either on my Mac which is not good itself. I > would > > >like to let you know that I build Moonshine IDE sources with the > binaries > > >and it's working perfectly fine. > > > > > >Thanks, Piotr > > > > > > > > >2017-11-14 1:17 GMT+01:00 Justin Mclean <jus...@classsoftware.com>: > > > > > >> Hi, > > >> > > >> > Which would effect the locale files i.e. the Chinese and Japanese > and > > >> probably French and other european language locales would be broken. > > >> > > >> Confirmed it’s an issue and I would also vote -1 binding because of > > >>that. > > >> > > >> To reproduce just view a DateChooser and you’ll see it has some ? in > > >>it’s > > >> display when using the Chinese and Japanese locales where other > > >>characters > > >> should be. > > >> > > >> Thanks, > > >> Justin > > > > > > > > > > > > > > >-- > > > > > >Piotr Zarzycki > > > > > >Patreon: > > >*https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Fwww.patr > > >eon.com%2Fpiotrzarzycki&data=02%7C01%7C%7Cfcef139cb31d4bfc2bf008d52b27 > bb9f > > >%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0% > 7C636462372052361116&sdata=Dc% > > >2B05mo72Kfp6REB3IniQTA1%2BkLnXl%2F9gKP%2ByWD8mkE%3D&reserved=0 > > ><https://na01.safelinks.protection.outlook.com/?url= > https%3A%2F%2Fwww.patr > > >eon.com%2Fpiotrzarzycki&data=02%7C01%7C%7Cfcef139cb31d4bfc2bf008d52b27 > bb9f > > >%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0% > 7C636462372052361116&sdata=Dc% > > >2B05mo72Kfp6REB3IniQTA1%2BkLnXl%2F9gKP%2ByWD8mkE%3D&reserved=0>* > > > > >
