Pretty sure it doesn't work without an Ant extension that sets environment variables, and there used to be pushback against using Ant extensions in our build scripts.
What should work is setting outputencoding on the Copy and maybe Move tasks in our scripts. We just need a volunteer to try it. I"ll probably try it on the next Royale release. I think 4.16.1 was the first Apache Flex release where the packaging was done on Windows instead of Mac which is why we ran into this issue. -Alex On 11/15/17, 7:09 AM, "Harbs" <harbs.li...@gmail.com> wrote: >+1. > >Definitely a good idea if it’ll work. > >> On Nov 15, 2017, at 11:18 AM, Maxim Solodovnik <solomax...@gmail.com> >>wrote: >> >> maybe this JAVA_TOOL_OPTIONS can be added to ant build as <property ? >> >> To avoid such issue in the future? >> >> On Wed, Nov 15, 2017 at 4:09 PM, Piotr Zarzycki >><piotrzarzyck...@gmail.com> >> wrote: >> >>> Another RC is coming. Cancel this one. >>> >>> 2017-11-15 9:04 GMT+01:00 Piotr Zarzycki <piotrzarzyck...@gmail.com>: >>> >>>> Hi Alex, >>>> >>>> I just tried JAVA_TOOL_OPTIONS and that was it! Thank you and I will >>>>cut >>>> another RC very soon! >>>> >>>> Piotr >>>> >>>> 2017-11-14 19:26 GMT+01:00 Alex Harui <aha...@adobe.com.invalid>: >>>> >>>>> I couldn't see the screenshot, but I assume it didn't match. The >>>>>goal >>> is >>>>> to get it to match. I still think the issue is the Ant Copy task. >>>>>Have >>>>> you tried using the JAVA_TOOL_OPTIONS environment variable? I know >>>>>the >>> CI >>>>> server is using it. >>>>> >>>>> >>>>> -Dfile.encoding=UTF8 >>>>> >>>>> Another option you have is to update the build.xml and set the >>>>> outputencoding="utf-8" on all file tasks. You will know you have it >>> right >>>>> when you can unpack the source package and the characters match up. >>> Until >>>>> then, it isn't really worth putting out another RC. >>>>> >>>>> Good luck, >>>>> -Alex >>>>> >>>>> From: Piotr Zarzycki <piotrzarzyck...@gmail.com<mailto: >>>>> piotrzarzyck...@gmail.com>> >>>>> Reply-To: "dev@flex.apache.org<mailto:dev@flex.apache.org>" < >>>>> dev@flex.apache.org<mailto:dev@flex.apache.org>> >>>>> Date: Tuesday, November 14, 2017 at 10:06 AM >>>>> To: "dev@flex.apache.org<mailto:dev@flex.apache.org>" < >>>>> dev@flex.apache.org<mailto:dev@flex.apache.org>> >>>>> Subject: Re: [DISCUSS] Release Apache Flex SDK 4.16.1 - RC1* >>>>> >>>>> Hi Alex, >>>>> >>>>> I'm running out of time for today, but I just look into the: >>>>> frameworks/tests/basicTests/spark/views/SortTests.mxml in my local >>>>> repository on Windows I see exactly same as you pasted here: >>>>> >>>>> "海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "川 (U+5DDD)"]); >>>>> >>>>> But when I unpack on my Windows RC2 sources from zip I see in that >>>>>file >>>>> this one: >>>>> >>>>> [Obraz w treści 1] >>>>> >>>>> Can you see screenshot above ? >>>>> >>>>> Thanks, Piotr >>>>> >>>>> >>>>> 2017-11-14 8:47 GMT+01:00 Alex Harui >>>>><aha...@adobe.com.invalid<mailto: >>>>> aha...@adobe.com.invalid>>: >>>>> Piotr, >>>>> >>>>> If you look at your repo's copy of >>>>> frameworks/tests/basicTests/spark/views/SortTests.mxml, around line >>>>>43 >>>>> you >>>>> should see: >>>>> >>>>> "海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "川 (U+5DDD)"]); >>>>> >>>>> Note the character before "(U+5DDD)". It should look like 1 curved >>>>>line >>>>> followed by 2 straight lines. >>>>> >>>>> >>>>> In the RC1 source package, it looked like this (on Mac): >>>>> >>>>> "海 (U+6D77)", "雨 (U+96E8)", "水 (U+6C34)", "?? (U+5DDD)"]); >>>>> >>>>> Note the "??" before "(U+5DDD)". And it also wasn't right on Windows >>>>> (en_US). >>>>> >>>>> >>>>> I'm wondering, what do you see on your system? And what do you see >>>>>in >>>>> RC2? I haven't looked yet, and I'm pretty much out of time for >>>>>tonight. >>>>> It could be that on your Windows system, even for RC1 you will see >>>>>the 1 >>>>> curved line followed by 2 straight lines. But I'm pretty sure your >>>>>Mac >>>>> should have the "??" for RC1. If RC2 has the 1 curved line followed >>>>>by >>>>> two 2 straight lines, then you probably got it right, but I'm more >>>>> suspicious of the Ant file manipulation than I am of Git's >>>>>manipulation >>> of >>>>> the files. >>>>> >>>>> If you don't touch line endings when you pull from Git, you still >>>>>should >>>>> ensure that the Windows .bat files have DOS line endings otherwise >>>>>they >>>>> become hard to read on Windows systems. I'm not sure the build >>>>>script >>> is >>>>> set up to do that. It might assume that if you are on Windows, you >>> don't >>>>> need to touch the .bat files. >>>>> >>>>> HTH, >>>>> -Alex >>>>> >>>>> On 11/13/17, 11:22 PM, "Piotr Zarzycki" >>>>><piotrzarzyck...@gmail.com<mai >>>>> lto:piotrzarzyck...@gmail.com>> wrote: >>>>> >>>>>> Alex, >>>>>> >>>>>> I understand what is all about with chmod as it was in FlexJS (not >>>>>>sure >>>>>> which file should be converted), but I would like to leave it as is >>> now. >>>>>> Unfortunately I don't understand your last sentence: >>>>>> >>>>>> "I was hoping the source files would be valid on Windows, but I just >>>>>> checked and even there they are not. I'm guessing that Piotr's >>>>>>default >>>>>> character encoding for Windows where he lives is different than US >>>>>> Windows. I'm not sure there is a workaround to convert those files >>> back >>>>>> to UTF8 or not. But given they don't look right in US Windows >>>>>>systems, >>>>>> unless there is an easy workaround, it might be a good idea to fix >>>>>>this >>>>>> issue in another RC." >>>>>> >>>>>> I just pushed RC2, where I have checkouted once again whole >>>>>>repository >>>>>> having all files unchanged in case of line endings. Now sh scripts >>>>>>are >>>>>> runnable on Mac. I just run also installer.xml and it's working. I >>>>>>will >>>>>> wait for Justin's look into the pushed RC2 before I officially cut >>>>>>it. >>>>>> >>>>>> Thanks, Piotr >>>>>> >>>>>> >>>>>> 2017-11-14 7:56 GMT+01:00 Alex Harui >>>>>><aha...@adobe.com.invalid<mailto: >>>>> aha...@adobe.com.invalid>>: >>>>>> >>>>>>> >>>>>>> >>>>>>> On 11/13/17, 6:27 PM, "Justin Mclean" >>>>>>><justinmcl...@me.com<mailto:ju >>>>> stinmcl...@me.com>> wrote: >>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>>> Is the DateChooser problem from your local build of the sources >>>>>>>>>or >>>>>>> from >>>>>>>>> the RC binary artifacts? >>>>>>>> >>>>>>>> A local built from the compiled source bundled I've not tested the >>>>>>> binary >>>>>>>> yet but given it was made from the source release I would expect >>>>>>>>it >>> to >>>>>>>> show the same issues. Or are you saying that the binary artefact >>>>>>>>was >>>>>>> not >>>>>>>> made from the code in the source release? >>>>>>> >>>>>>> The binaries are not created by first creating the source package, >>>>>>> unpacking it and compiling it. You were a Flex SDK RM at least >>>>>>>once, >>>>>>> did >>>>>>> you not understand what you were signing? The build builds the >>> sources >>>>>>> it >>>>>>> got from the repo and assumes that the copy to the temp folder to >>>>> create >>>>>>> the source package will not modify the files, but it looks like at >>>>> least >>>>>>> on Windows, Ant will change the character encoding in the copy >>>>>>>unless >>>>>>> you >>>>>>> use JAVA_TOOL_OPTIONS. That is something we should figure out how >>>>>>>to >>>>>>> prevent in the future, either by documenting how to prevent >>>>>>>character >>>>>>> encoding changes or by changing the build script. And in my tests, >>> the >>>>>>> binary artifact did work correctly. >>>>>>>> >>>>>>>> Either way it's the source that’s the offical release and it seems >>>>>>>> unusual to release a broken source release even if the binary did >>>>> work. >>>>>>> >>>>>>> I was hoping the source files would be valid on Windows, but I just >>>>>>> checked and even there they are not. I'm guessing that Piotr's >>> default >>>>>>> character encoding for Windows where he lives is different than US >>>>>>> Windows. I'm not sure there is a workaround to convert those files >>>>> back >>>>>>> to UTF8 or not. But given they don't look right in US Windows >>> systems, >>>>>>> unless there is an easy workaround, it might be a good idea to fix >>> this >>>>>>> issue in another RC. >>>>>>> >>>>>>> -Alex >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> >>>>>> Piotr Zarzycki >>>>>> >>>>>> Patreon: >>>>>> *https://na01.safelinks.protection.outlook.com/?url=https% >>>>> 3A%2F%2Fwww.patr >>>>>> eon.com<https://na01.safelinks.protection.outlook.com/?url= >>>>> http%3A%2F%2Feon.com&data=02%7C01%7C%7Cbbfcf475660b4a5b6667 >>>>> 08d52b8a666e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63 >>>>> 6462795785096599&sdata=RXYk9VGEGZtdX8fa6CD0aGCy4NOAW9HCknpvE >>>>> drQvmw%3D&reserved=0>%2Fpiotrzarzycki&data=02%7C01%7C%7C05fe >>>>> f9a080cd4c323c8b08d52b307cc5 >>>>>> %7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6364624096102 >>>>> 37907&sdata=Dy2 >>>>>> BgGtCgZ7r7k%2FricqDFyij5o9KzTSwURSD%2F1un64Q%3D&reserved=0 >>>>>> <https://na01.safelinks.protection.outlook.com/?url=https% >>>>> 3A%2F%2Fwww.patr >>>>>> eon.com<https://na01.safelinks.protection.outlook.com/?url= >>>>> http%3A%2F%2Feon.com&data=02%7C01%7C%7Cbbfcf475660b4a5b6667 >>>>> 08d52b8a666e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63 >>>>> 6462795785096599&sdata=RXYk9VGEGZtdX8fa6CD0aGCy4NOAW9HCknpvE >>>>> drQvmw%3D&reserved=0>%2Fpiotrzarzycki&data=02%7C01%7C%7C05fe >>>>> f9a080cd4c323c8b08d52b307cc5 >>>>>> %7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6364624096102 >>>>> 37907&sdata=Dy2 >>>>>> BgGtCgZ7r7k%2FricqDFyij5o9KzTSwURSD%2F1un64Q%3D&reserved=0>* >>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> >>>>> Piotr Zarzycki >>>>> >>>>> Patreon: >>>>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.p >>>>>atreon.com%2Fpiotrzarzycki&data=02%7C01%7C%7C42807aebe4944b8a78db08d52 >>>>>c3ae80d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63646355388967911 >>>>>4&sdata=T3Hzmv1hKQUaUmLkV%2B%2BeDzVljIY%2Fm4HkJmoXCOfdgF8%3D&reserved= >>>>>0<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fna0 >>>>>1.safelinks&data=02%7C01%7C%7C42807aebe4944b8a78db08d52c3ae80d%7Cfa7b1 >>>>>b5a7b34438794aed2c178decee1%7C0%7C0%7C636463553889679114&sdata=V3KWKcG >>>>>GHqgEBhbLhORS%2BkyoVcYetEgbXk4d%2F6bb2%2F0%3D&reserved=0 >>>>> .protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com% >>>>> 2Fpiotrzarzycki&data=02%7C01%7C%7Cbbfcf475660b4a5b666708d52 >>>>> b8a666e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6364627 >>>>> 95785096599&sdata=jJosNusW2Z7AwP3frtCOmTqoKl5G42ON1ffOSBxO1z >>>>> g%3D&reserved=0> >>>>> >>>> >>>> >>>> >>>> -- >>>> >>>> Piotr Zarzycki >>>> >>>> Patreon: >>>>*https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.p >>>>atreon.com%2Fpiotrzarzycki&data=02%7C01%7C%7C42807aebe4944b8a78db08d52c >>>>3ae80d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636463553889679114& >>>>sdata=T3Hzmv1hKQUaUmLkV%2B%2BeDzVljIY%2Fm4HkJmoXCOfdgF8%3D&reserved=0 >>>> >>>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.p >>>>atreon.com%2Fpiotrzarzycki&data=02%7C01%7C%7C42807aebe4944b8a78db08d52c >>>>3ae80d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636463553889679114& >>>>sdata=T3Hzmv1hKQUaUmLkV%2B%2BeDzVljIY%2Fm4HkJmoXCOfdgF8%3D&reserved=0>* >>>> >>> >>> >>> >>> -- >>> >>> Piotr Zarzycki >>> >>> Patreon: >>>*https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.pa >>>treon.com%2Fpiotrzarzycki&data=02%7C01%7C%7C42807aebe4944b8a78db08d52c3a >>>e80d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636463553889679114&sda >>>ta=T3Hzmv1hKQUaUmLkV%2B%2BeDzVljIY%2Fm4HkJmoXCOfdgF8%3D&reserved=0 >>> >>><https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.pa >>>treon.com%2Fpiotrzarzycki&data=02%7C01%7C%7C42807aebe4944b8a78db08d52c3a >>>e80d%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636463553889679114&sda >>>ta=T3Hzmv1hKQUaUmLkV%2B%2BeDzVljIY%2Fm4HkJmoXCOfdgF8%3D&reserved=0>* >>> >> >> >> >> -- >> WBR >> Maxim aka solomax >
