Thanks for pointing out the requirements in the README. I'll be sure to update that for the tests fix.
-- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Mon, Feb 13, 2023 at 3:20 AM Yishay Weiss <yishayj...@hotmail.com> wrote: > This is actually stated in the README, sorry for missing that. If you do > decide to fix this issue you should probably modify the Install > Prerequisites section in README as well. > > Thanks for doing this > > From: Josh Tynjala<mailto:joshtynj...@bowlerhat.dev> > Sent: Thursday, February 9, 2023 6:24 PM > To: dev@flex.apache.org<mailto:dev@flex.apache.org> > Subject: Re: [DISCUSS] Release Apache flex-sdk-converter-maven-extension > 1.1.0 RC1 > > I confirm that PlatformTypeTest fails with JDK 17, but works in JDK 8 and > 11. The test seems to be using reflection to change a private property in > the JDK to non-final so that it can pretend to be running on a different > platform temporarily. Some quick research turned up that the JDK authors > made things stricter in JDK 12 because doing something like this should not > be encouraged. > > This test is broken, but the behavior of flex-sdk-converter-maven-extension > is still correct. I will definitely fix the test for future releases. > > Yishay, would you be willing to test `mvn clean install` with JDK 11 so > that we don't need to do a new RC? If you're going to try it with > royale-compiler, you can switch back to JDK 17 for that. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Wed, Feb 8, 2023 at 11:10 PM Yishay Weiss <yishayj...@hotmail.com> > wrote: > > > I’m getting this: > > > > C:\dev\apache-flex-sdk-converter-1.1.0>mvn clean install > > Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF-8 > > [INFO] Scanning for projects... > > [INFO] > > ------------------------------------------------------------------------ > > [INFO] Reactor Build Order: > > [INFO] > > [INFO] Apache Flex - SDK-Converter > > [pom] > > [ > > (…) > > > > [INFO] T E S T S > > [INFO] ------------------------------------------------------- > > [INFO] Running > > org.apache.flex.utilities.converter.retrievers.types.PlatformTypeTest > > [ERROR] Tests run: 5, Failures: 0, Errors: 5, Skipped: 0, Time elapsed: > > 0.082 s <<< FAILURE! - in > > org.apache.flex.utilities.converter.retrievers.types.PlatformTypeTest > > [ERROR] [0] IS_OS_WINDOWS, WINDOWS > > > (it_detects_the_current_platform_type)(org.apache.flex.utilities.converter.retrievers.types.PlatformTypeTest) > > Time elapsed: 0.009 s <<< ERROR! > > java.lang.NoSuchFieldException: modifiers > > at > > > org.apache.flex.utilities.converter.retrievers.types.PlatformTypeTest.setFinalStatic(PlatformTypeTest.java:74) > > at > > > org.apache.flex.utilities.converter.retrievers.types.PlatformTypeTest.setUp(PlatformTypeTest.java:51) > > > > From: Josh Tynjala<mailto:joshtynj...@bowlerhat.dev> > > Sent: Friday, February 3, 2023 6:23 PM > > To: dev@flex.apache.org<mailto:dev@flex.apache.org> > > Subject: Re: [DISCUSS] Release Apache flex-sdk-converter-maven-extension > > 1.1.0 RC1 > > > > At minimum, extract the source-release .zip file and run `mvn clean > > install` in the root directory that contains pom.xml. > > > > OPTIONAL: After `mvn clean isntall`, you can also test that it works with > > the royale-compiler repo (be sure to pull the latest commits). Here's > what > > you need to do: > > > > (Prerequisite: Make sure that you have the FLASHPLAYER_DEBUGGER env var > > pointing to a Flash Player projector executable. If you don't have this > > executable already, the royale-compiler README explains how you can still > > download it from Adobe.) > > > > 1. In royale-compiler, go into .mvn/extensions.xml and set the version to > > 1.1.0: <version>1.1.0</version> > > 2. Go into ~/.m2/repository/com/adobe/flash/ and move the "framework" > > directory somewhere else temporarily. This lets you put it back later, if > > something goes wrong. > > 3. In royale-compiler, run `mvn clean install -P option-with-swf`. > > > > If the royale-compiler option-with-swf build passes, then the extension > > successfully installed playerglobal 32.0. > > > > -- > > Josh Tynjala > > Bowler Hat LLC <https://bowlerhat.dev> > > > > > > On Thu, Feb 2, 2023 at 11:28 PM Harbs <harbs.li...@gmail.com> wrote: > > > > > What do I need to do to test this? > > > > > > > On Feb 3, 2023, at 1:15 AM, Josh Tynjala <joshtynj...@bowlerhat.dev> > > > wrote: > > > > > > > > Hi, > > > > > > > > Please discuss the flex-sdk-converter-maven-extension 1.1.0 release > > > > candidate here and not in the vote thread. > > > > > > > > Thanks, > > > > Josh > > > > > > > > > > > >
