Hi Matthias! You are right, the package is actually wrong. Strange that the compiler never complained.
Can you submit a patch? Stephan On Tue, Feb 24, 2015 at 7:02 PM, Matthias J. Sax < mj...@informatik.hu-berlin.de> wrote: > Hi, > > it builds after a fresh checkout. However, the file I mentioned is still > buggy IMHO. > > > mjsax@T420s-dbis-mjsax:~/workspace_flink/dummy/flink$ grep package > flink-java/src/test/java/org/apache/flink/api/java/typeutils/runtime/kryo/KryoWithCustomSerializersTest.java > > package org.apache.flink.api.java.typeutils.runtime; > > So, from my understanding it should not build... Is this file somehow > skipped? Might it be, that eclipse messes up my original environment? > > > -Matthias > > > > On 02/24/2015 06:36 PM, Fabian Hueske wrote: > > The master builds for me as well. > > Can you try to clone a new copy and do a "mvn -DskipTests clean install"? > > > > 2015-02-24 18:26 GMT+01:00 Matthias J. Sax < > mj...@informatik.hu-berlin.de>: > > > >> Hi, > >> > >> I build on command line: > >> > >> mjsax@T420s-dbis-mjsax:~/workspace_flink/flink$ git pull flink master > >> From https://github.com/apache/flink > >> * branch master -> FETCH_HEAD > >> Already up-to-date. > >> > >> The problem is in TEST: > >> > >> > flink-java/src/test/java/org/apache/flink/api/java/typeutils/runtime/kryo/KryoWithCustomSerializersTest.java > >> > >> I fixed the bug and git diff gives me: > >>> mjsax@T420s-dbis-mjsax:~/workspace_flink/flink$ git diff > >> > flink-java/src/test/java/org/apache/flink/api/java/typeutils/runtime/kryo/KryoWithCustomSerializersTest.java > >>> diff --git > >> > a/flink-java/src/test/java/org/apache/flink/api/java/typeutils/runtime/kryo/KryoWithCustomSerializersTest.java > >> > b/flink-java/src/test/java/org/apache/flink/api/java/typeutils/runtime/kryo/KryoWithCustomSerializersTest.java > >>> index 155010e..d68afd6 100644 > >>> --- > >> > a/flink-java/src/test/java/org/apache/flink/api/java/typeutils/runtime/kryo/KryoWithCustomSerializersTest.java > >>> +++ > >> > b/flink-java/src/test/java/org/apache/flink/api/java/typeutils/runtime/kryo/KryoWithCustomSerializersTest.java > >>> @@ -16,7 +16,7 @@ > >>> * limitations under the License. > >>> */ > >>> > >>> -package org.apache.flink.api.java.typeutils.runtime; > >>> +package org.apache.flink.api.java.typeutils.runtime.kryo; > >>> > >>> import java.util.Collection; > >>> import java.util.HashSet; > >>> @@ -25,6 +25,7 @@ import org.apache.flink.api.common.ExecutionConfig; > >>> import org.apache.flink.api.common.typeinfo.TypeInformation; > >>> import org.apache.flink.api.common.typeutils.TypeSerializer; > >>> import org.apache.flink.api.java.typeutils.GenericTypeInfo; > >> > >> > >> > >> As you can see, the class is in .../runtim/kryo/ but the package > >> statement omits the ".kryo" > >> > >> > >> -Matthias > >> > >> > >> > >> > >> On 02/24/2015 05:47 PM, Robert Metzger wrote: > >>> How did you build Flink? > >>> > >>> I'm not so sure if the master is really broken because I've build it > >>> multiple times today, also our Travis says everything is fine: > >>> https://travis-ci.org/apache/flink/builds > >>> > >>> > >>> On Tue, Feb 24, 2015 at 5:29 PM, Matthias J. Sax < > >>> mj...@informatik.hu-berlin.de> wrote: > >>> > >>>> Hi, > >>>> > >>>> I just pulled the latest version "flink master" and I got a > compilation > >>>> error. I tracked the bug down. It seems that the following commit > moved > >>>> a class without changing the package statement... > >>>> > >>>> > >>>> Cheers, > >>>> Matthias > >>>> > >>>> > >>>> commit 354efec0f9da0fa03ea9b337b02a1a2a03a9ac16 > >>>> Author: Robert Metzger <rmetz...@apache.org> 2015-01-26 17:54:25 > >>>> Committer: Robert Metzger <rmetz...@apache.org> 2015-02-18 15:52:08 > >>>> Parent: 7407076d3990752eb5fa4072cd036efd2f656cbc ([FLINK-1369] [types] > >>>> Add support for Subclasses, Interfaces, Abstract Classes.) > >>>> Branches: master, flink/master > >>>> > >>>> [FLINK-1417] Automatically register types with Kryo > >>>> > >>>> > >>>>> diff --git > >>>> > >> > a/flink-java/src/test/java/org/apache/flink/api/java/typeutils/runtime/KryoWithCustomSerializersTest.java > >>>> > >> > b/flink-java/src/test/java/org/apache/flink/api/java/typeutils/runtime/kryo/KryoWithCustomSerializersTest.java > >>>>> similarity index 96% > >>>>> rename from > >>>> > >> > flink-java/src/test/java/org/apache/flink/api/java/typeutils/runtime/KryoWithCustomSerializersTest.java > >>>>> rename to > >>>> > >> > flink-java/src/test/java/org/apache/flink/api/java/typeutils/runtime/kryo/KryoWithCustomSerializersTest.java > >>>>> index 7020d80..155010e 100644 > >>>>> --- > >>>> > >> > a/flink-java/src/test/java/org/apache/flink/api/java/typeutils/runtime/KryoWithCustomSerializersTest.java > >>>>> +++ > >>>> > >> > b/flink-java/src/test/java/org/apache/flink/api/java/typeutils/runtime/kryo/KryoWithCustomSerializersTest.java > >>>>> @@ -50,7 +50,7 @@ > >>>>> @Override > >>>>> protected <T> TypeSerializer<T> createSerializer(Class<T> > type) { > >>>>> ExecutionConfig conf = new ExecutionConfig(); > >>>>> - conf.registerKryoSerializer(LocalDate.class, > >>>> LocalDateSerializer.class); > >>>>> + conf.registerTypeWithKryoSerializer(LocalDate.class, > >>>> LocalDateSerializer.class); > >>>>> TypeInformation<T> typeInfo = new > >> GenericTypeInfo<T>(type); > >>>>> return typeInfo.createSerializer(conf); > >>>>> } > >>>> > >>>> > >>>> > >>> > >> > >> > > > >
