@Max: The PR is good to go on my side. Does the job, could be a bit nicer though. Added to the document.
On Tue, Jun 16, 2015 at 10:54 PM, Aljoscha Krettek <aljos...@apache.org> wrote: > I added the two relevant Table API commits to the release doc. > > On Tue, 16 Jun 2015 at 21:49 Maximilian Michels <m...@apache.org> wrote: > > > +1 for adding the Table API fixes. > > > > @Till: It seems like you fixed the bug in the scheduler. Is > > https://github.com/apache/flink/pull/843 fixing it? > > > > @Marton: What's the state of your pull request to solve the license issue > > of the shaded dependencies? https://github.com/apache/flink/pull/837 > > > > I'm assuming all necessary fixes have been added to the document. The > ones > > in now look ok to me. > > On Jun 16, 2015 6:52 PM, "Fabian Hueske" <fhue...@gmail.com> wrote: > > > > Important fixes, IMO. +1 for adding. > > > > 2015-06-16 18:50 GMT+02:00 Aljoscha Krettek <aljos...@apache.org>: > > > > > I would like to include the fixes for the Table API: RowSerializer > > supports > > > null values, Aggregations properly deal with null values. > > > > > > What do you think? > > > > > > On Mon, 15 Jun 2015 at 17:31 Aljoscha Krettek <aljos...@apache.org> > > wrote: > > > > > > > I created this to help with release testing: > > > > https://github.com/aljoscha/FliRTT > > > > > > > > You just start your cluster and then point the tool to the Flink > > > > directory. It will then run all the examples with both builtin data > and > > > > external data. > > > > > > > > On Mon, 15 Jun 2015 at 17:15 Maximilian Michels <m...@apache.org> > > wrote: > > > > > > > >> Hmm. Might be interesting to check out whether this is a regression > > from > > > >> rc1 to rc2. In any case, it is a serious release blocker and we need > > to > > > >> fix > > > >> it. > > > >> > > > >> On Mon, Jun 15, 2015 at 5:04 PM, Till Rohrmann < > trohrm...@apache.org> > > > >> wrote: > > > >> > > > >> > I might have found another release blocker. While running some > > cluster > > > >> > tests I also tried to run the `ConnectedComponents` example. > > However, > > > >> > sometimes the example couldn't be executed because the scheduler > > could > > > >> not > > > >> > schedule co-located tasks, `NoResourceAvailableException`, even > > though > > > >> it > > > >> > should have had enough slots. It also happened on a fresh Flink > > > >> cluster. I > > > >> > opened a corresponding JIRA issue [1]. > > > >> > > > > >> > The error seems to be similar to the error reported in FLINK-1952 > > [2]. > > > >> > However, I thought that this problem was already fixed. But maybe > > the > > > >> error > > > >> > was reintroduced by the latest change to the scheduler, FLINK-2183 > > [3, > > > >> 4]. > > > >> > > > > >> > [1] https://issues.apache.org/jira/browse/FLINK-2225 > > > >> > [2] https://issues.apache.org/jira/browse/FLINK-1952 > > > >> > [3] https://issues.apache.org/jira/browse/FLINK-2183 > > > >> > [4] > > > >> > > > > >> > > > > >> > > > > > > > > https://github.com/apache/flink/commit/e966a0dd1c9f35ba6cb0ff4e09205c411fc4585d > > > >> > > > > >> > On Mon, Jun 15, 2015 at 3:45 PM Ufuk Celebi <u...@apache.org> > wrote: > > > >> > > > > >> > > Please continue the discussion in the issue Aljoscha opened: > > > >> > > https://issues.apache.org/jira/browse/FLINK-2221 > > > >> > > > > > >> > > I think it is better to only point to issues in this mail > thread. > > > >> > > Otherwise the discussions are very hard to follow. > > > >> > > > > > >> > > > > > >> > > > > >> > > > > > > > > > >