Hi Sachin, I’m sorry for your unsatisfied experience about lack of review.
As you know, because there are few committers (including me) whose interest is ML, the review of PRs could be completed slowly. But I admit my fault about leaving the PRs unreviewed for 3-5 months. I’ll try to review your PRs as soon as possible. > On Dec 6, 2015, at 1:00 AM, Sachin Goel <sachingoel0...@gmail.com> wrote: > > Hi all > Sorry about a weekend email. > > This email is to express my displeasure over the lack of any review on my > PRs on extending the ML library. Five of my PRs have been without any > review for times varying from 3-5 months now. > When I took up the task of extending the ML library by implementing core > algorithms such as Decision Tree and k-means clustering [with several > initialization schemes], I had hoped that the community will be actively > involved in it since ML is a very important component of any big data > system these days. However, it appears I have been wrong. > Surely, the initial reviews required a lot of changes from my side over > coding style mistakes [first time programmer in Scala], and > less-than-optimal implementations. I like to think that I have learned a > lot about maintaining better coding style compatible with Flink code base, > and spending time to optimize my work due to this. > However, if a PR requires work, that doesn't automatically disqualify it > from being reviewed actively, since the author has spent a lot of time on > it and has voluntarily taken up the task of contributing. > > Machine learning is my core area of interest and I am able to contribute > much more to the library; however, a lack of review after repeated > reminders automatically discourages me from picking up more issues. > > However minor some of my commits maybe, I have been actively involved in > the development work [with a total of 29 commits.]. I have also spent a lot > of time in release testing and diagnosing-slash-fixing lots of issues with > Web Dashboard. However, as with any contributor, my main goal is to > contribute to my area of interest, while also diversifying my work by > fixing other issues. > > The PRs are 710, 757, 861, 918 and 1032. I propose the following order for > anyone who wants to review my work: > 1032 [very simple feature.] > 918 [very short PR] > 861 [followed by 710 after a complete rebase] [major work for Histograms > and Decision Trees] > 757 [major work for K-Means clustering and initialization schemes] > > If I have come across as rude, I apologize. > > Happy reviewing and thanks for bearing with me. :) > > Cheers! > Sachin > > -- Sachin Goel > Computer Science, IIT Delhi > m. +91-9871457685 Regards, Chiwan Park
