Do we plan to include something like this in the contribution guide as well?
On Thu, Apr 28, 2016 at 3:16 PM, Stefano Baghino < stefano.bagh...@radicalbit.io> wrote: > Awesome Dawid! Thanks for taking the time to do this. :) > > On Thu, Apr 28, 2016 at 1:45 PM, Dawid Wysakowicz < > wysakowicz.da...@gmail.com> wrote: > > > Hi, > > > > I tried to create a code style that would follow Flink code-style. It may > > be not "production" ready, but I think it can be a good start. > > Hope it will be useful for someone. Also I will be glad for any comments > > on that. > > > > 2016-04-10 13:59 GMT+02:00 Stephan Ewen <se...@apache.org>: > > > >> I don't know how close Phoenix' code style is to Flink's de-facto code > >> style. > >> I would create one that reflects Flink's de-facto code style, so that > the > >> formatter does not change everything... > >> > >> On Sun, Apr 10, 2016 at 4:40 AM, Naveen Madhire <vmadh...@umail.iu.edu> > >> wrote: > >> > >> > Apache Phoenix has one code template which contributors use. Do you > >> think > >> > onc can use the same for Flink or may be with some more modifications? > >> > > >> > > >> > > >> > https://github.com/apache/phoenix/blob/master/dev/PhoenixCodeTemplate.xml > >> > > >> > On Sat, Apr 9, 2016 at 11:00 AM, Stephan Ewen <se...@apache.org> > wrote: > >> > > >> > > Actually, It would be amazing to create a code style profile for > >> > download, > >> > > so that all contributors would use that. > >> > > > >> > > Same thing actually for IntelliJ inspections: A set of inspections > we > >> > want > >> > > to have active and where we strive for zero warnings. > >> > > > >> > > On Sat, Apr 9, 2016 at 10:00 AM, Robert Metzger < > rmetz...@apache.org> > >> > > wrote: > >> > > > >> > > > Hi Dawid, > >> > > > > >> > > > we don't have an automated formatter for intelliJ. However, you > can > >> use > >> > > the > >> > > > "Checkstyle" plugin of IntelliJ to mark checkstyle violations in > the > >> > IDE. > >> > > > > >> > > > On Fri, Apr 8, 2016 at 12:30 PM, Dawid Wysakowicz < > >> > > > wysakowicz.da...@gmail.com> wrote: > >> > > > > >> > > > > Hi all, > >> > > > > > >> > > > > I am currently working on some issues and been wondering if you > >> have > >> > > > > settings for Intellij code style that would follow your coding > >> > > guidelines > >> > > > > available (I tried to look on wikis but could not find it). If > not > >> > > could > >> > > > > someone share its own? I would be grateful. > >> > > > > > >> > > > > Regards > >> > > > > Dawid Wysakowicz > >> > > > > > >> > > > > >> > > > >> > > >> > > > > > > > -- > BR, > Stefano Baghino > > Software Engineer @ Radicalbit >
