+1 I like it a lot. Much clearer and better maintainable!
Do we have a plan to migrate ConfigConstants to the new ConfigOptions?
Where do we maintain a list of all config options?
-Max
On Wed, Oct 26, 2016 at 2:36 PM, Stephan Ewen <se...@apache.org> wrote:
> Hi all!
>
> A few weeks back we introduced a new way to define configuration parameters.
> I would like to encourage everyone to use that new pattern for all new
> options that we create, and lazily migrate existing parameters to that
> pattern.
>
> The current way of maintaining keys, defaults, and deprecated keys manually
> in the "ConfigConstants" class started to become unmaintainable.
>
> The new approach is based on the "ConfigOption" class and defines keys,
> deprecated keys, and default values together. For example:
>
> ConfigOption<Double> threshold = ConfigOptions
> .key("cpu.utilization.threshold")
> .defaultValue(0.9).
> .withDeprecatedKeys("cpu.threshold");
>
>
> Have a look at this class for a complete example:
> https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/HighAvailabilityOptions.java
>
>
> Greetings,
> Stephan
