Hello Theodore,
Thanks for your reply.
Of course. I would have done that in the first place but I had seen the
contribution guideline advising to avoid WIP PRs:
"No WIP pull requests. We consider pull requests as requests to merge
the referenced code as is into the current stable master branch.
Therefore, a pull request should not be “work in progress”. Open a pull
request if you are confident that it can be merged into the current
master branch without problems. If you rather want comments on your
code, post a link to your working branch."
I don't know the rationale behind this, as a WIP PR seems most of the
time a convenient way to share half-finished code. Maybe I'll open a
discussion about this.
I'll open a WIP PR for this after cleaning our code a bit.
Cheers,
Gabor
On 2016-11-10 16:56, Theodore Vasiloudis wrote:
Hello Gabor,
for this type of issue (design decisions) what we've done in the past with
FlinkML is to open a PR marked with the WIP tag and take the discussion
there, making it easier
for people to check out the code and get a feel of advantages/disadvantages
of different approaches.
Could you do that for this issue?
Regards,
Theodore
On Thu, Nov 10, 2016 at 12:46 PM, Gábor Hermann <m...@gaborhermann.com>
wrote:
Hi all,
We have managed to fit the ranking recommendation evaluation into the
evaluation framework proposed by Thedore (FLINK-2157). There's one main
problem, that remains: we have to different predictor traits (Predictor,
RankingPredictor) without a common superclass, and that might be
problematic.
Please see the details at the issue:
https://issues.apache.org/jira/browse/FLINK-4713
Could you give feedback on whether we are moving in the right direction or
not? Thanks!
Cheers,
Gabor
