Hi, Fabian, Jark Wu, Greg Thank for your feedback and support. I’ll create some sub-issue to complete the every task of code refactor.
在 2017/3/27 下午3:38， "Fabian Hueske" <fhue...@gmail.com> 写入: >Hi Jinkui, > >I agree with you, moving all examples into ./examples would be nice. >Note, that for the DataSet and DataStream APIs, each example is packaged >as >a separate JAR with the main class being included in the MANIFEST file. > >I think we should select a few representative examples of the Table and >Gelly examples and do the same. >IMO, the Table API / SQL examples could also be improved a lot, but that's >a different story. > >Best, Fabian > >2017-03-27 5:47 GMT+02:00 伍翀(云邪) <wuchong...@alibaba-inc.com>: > >> Hi Jinkui, >> >> Thanks for bringing up this discussion. I’m +1 to moving table-examples >> and belly-examples into "examples/“ to keep “opt” clean. >> >> Best, >> Jark Wu >> >> > 在 2017年3月25日，下午3:46，shijinkui <shijin...@huawei.com> 写道： >> > >> > Hi, all >> > >> > The Flink distributionĄ¯s directory have no very clear responsibility >> about what type of files should be in which directory. >> > >> > The "bin","conf","lib" directories are clear for their responsibility. >> > >> > But the Ą°opt" directories are mixed with library jars and example >>jars. >> > >> > I think we can discuss how is reasonable for the directory. Once we >> determined, we should follow it. >> > >> > IMO, directory style below is reasonable: >> > >> > - "examples" directory only contain example jars >> > - "opt" directory only contain optional library jars in runtime >> > - "lib" directory only contain library jar that must be loaded at >>runtime >> > - Ą°resourcesĄą directory only contain resource file used at runtime, >> such as web file >> > >> > Show your opinion please. >> > >> > @wuchong, @fhueske @Fabian >> > >> > Best regards, >> > Jinkui Shi >> > >> > >> > . >> > ŠĀŠ¤Š¤ LICENSE >> > ŠĀŠ¤Š¤ NOTICE >> > ŠĀŠ¤Š¤ README.txt >> > ŠĀŠ¤Š¤ bin >> > ŠĻ ŠĀŠ¤Š¤ config.sh >> > ŠĻ ŠĀŠ¤Š¤ flink >> > ŠĻ ŠĀŠ¤Š¤ ... >> > ŠĀŠ¤Š¤ conf >> > ŠĻ ŠĀŠ¤Š¤ flink-conf.yaml >> > ŠĻ ŠĀŠ¤Š¤ ... >> > ŠĀŠ¤Š¤ examples >> > ŠĻ ŠĀŠ¤Š¤ batch >> > ŠĻ Š¸Š¤Š¤ streaming >> > ŠĀŠ¤Š¤ lib >> > ŠĻ ŠĀŠ¤Š¤ flink-dist_2.11-1.3.0.jar >> > ŠĻ ŠĀŠ¤Š¤ flink-python_2.11-1.3.0.jar >> > ŠĻ ŠĀŠ¤Š¤ ... >> > ŠĀŠ¤Š¤ log >> > ŠĀŠ¤Š¤ opt >> > ŠĻ ŠĀŠ¤Š¤ flink-cep-scala_2.11-1.3.0.jar >> > ŠĻ ŠĀŠ¤Š¤ flink-cep_2.11-1.3.0.jar >> > ŠĻ ŠĀŠ¤Š¤ flink-gelly-examples_2.11-1.3.0.jar >> > ŠĻ ŠĀŠ¤Š¤ flink-gelly-scala_2.11-1.3.0.jar >> > ŠĻ ŠĀŠ¤Š¤ flink-gelly_2.11-1.3.0.jar >> > ŠĻ ŠĀŠ¤Š¤ flink-metrics-dropwizard-1.3.0.jar >> > ŠĻ ŠĀŠ¤Š¤ flink-metrics-ganglia-1.3.0.jar >> > ŠĻ ŠĀŠ¤Š¤ flink-metrics-graphite-1.3.0.jar >> > ŠĻ ŠĀŠ¤Š¤ flink-metrics-statsd-1.3.0.jar >> > ŠĻ Š¸Š¤Š¤ flink-ml_2.11-1.3.0.jar >> > ŠĀŠ¤Š¤ resources >> > ŠĻ Š¸Š¤Š¤ python >> > Š¸Š¤Š¤ tools >> > Š¸Š¤Š¤ planVisualizer.html >> > >> > >> > [1] https://github.com/apache/flink/pull/2460 >> > >> >>
