+10 I think it makes sense spark is also using 2.11 as the default for quite some time.
On Thu, Jun 29, 2017 at 8:14 PM, Bowen Li <bowen...@offerupnow.com> wrote: > EMR's builtin Flink is always 1 or 2 versions behind Flink latest release. > We choose to install Flink on EMR ourselves. > > On Thu, Jun 29, 2017 at 2:37 AM, 郭健 <guo.j...@immomo.com> wrote: > > > +1 > > Most of the time I need to build scala-2.11 version, although I can use > > the script tools/change-version.sh to change scala version in all poms, > it > > breaks the code consistency with the master branch. > > > > Aegeaner > > > > > > On 6/28/17, 22:23, "Piotr Nowojski" <pi...@data-artisans.com> wrote: > > > > Yes, I know and I’m proposing to change this in parent pom by default > > to scala-2.11. > > > > Changing parent pom every time anyone wants to touch/build in > Intellij > > Kafka 0.11 connector is not a great idea. This would require a developer > to > > constantly stash those changes or commit and revert them before creating > a > > pull request. > > > > Piotrek > > > > > On Jun 28, 2017, at 3:49 PM, Greg Hogan <c...@greghogan.com> > wrote: > > > > > > You don't need to use the build profile in IntelliJ, just change > > > scala.version and scala.binary.version in the parent pom (recent > > > refactorings made this possible without changing every pom). > > > > > > What is the benefit for changing the default without dropping older > > > versions when contributions are still limited to the functionality > > of the > > > old version? > > > > > > On Wed, Jun 28, 2017 at 8:36 AM, Piotr Nowojski < > > pi...@data-artisans.com> > > > wrote: > > > > > >> Hi, > > >> > > >> I propose to switch to Scala 2.11 as a default and to have a Scala > > 2.10 > > >> build profile. Now it is other way around. The reason for that is > > poor > > >> support for build profiles in Intellij, I was unable to make it > > work after > > >> I added Kafka 0.11 dependency (Kafka 0.11 dropped support for > Scala > > 2.10). > > >> > > >> As a side note, maybe we should also consider dropping Scala 2.10 > > support? > > >> > > >> Piotrek > > > > > > > > >
