Good catch, yes. This shouldn't block the release, though, since the doc is always built form the latest state of a release branch, i.e. the 1.4 doc on the website will update as soon as the doc on the release-1.4 branch is updated.
> On 6. Dec 2017, at 20:47, Bowen Li <bowen...@offerupnow.com> wrote: > > Hi Aljoscha, > > I found Flink's State doc and javaDoc are very ambiguous on what the > replacement of FoldingState is, which will confuse a lot of users. We need > to fix it in 1.4 release. > > I have submitted a PR at https://github.com/apache/flink/pull/5129 > > Thanks, > Bowen > > > On Wed, Dec 6, 2017 at 5:56 AM, Aljoscha Krettek <aljos...@apache.org> > wrote: > >> Hi everyone, >> >> Please review and vote on release candidate #3 for the version 1.4.0, as >> follows: >> [ ] +1, Approve the release >> [ ] -1, Do not approve the release (please provide specific comments) >> >> >> The complete staging area is available for your review, which includes: >> * JIRA release notes [1], >> * the official Apache source release and binary convenience releases to be >> deployed to dist.apache.org[2], which are signed with the key with >> fingerprint F2A67A8047499BBB3908D17AA8F4FD97121D7293 [3], >> * all artifacts to be deployed to the Maven Central Repository [4], >> * source code tag "release-1.4.0-rc1" [5], >> * website pull request listing the new release [6]. >> >> Please have a careful look at the website PR because I changed some >> wording and we're now also releasing a binary without Hadoop dependencies. >> >> Please use this document for coordinating testing efforts: [7] >> >> The only change between RC1 and this RC2 is that the source release >> package does not include the erroneously included binary Ruby dependencies >> of the documentation anymore. Because of this I would like to propose a >> shorter voting time and close the vote around the time that RC1 would have >> closed. This would mean closing by end of Wednesday. Please let me know if >> you disagree with this. The vote is adopted by majority approval, with at >> least 3 PMC affirmative votes. >> >> Thanks, >> Your friendly Release Manager >> >> [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa? >> projectId=12315522&version=12340533 >> [2] http://people.apache.org/~aljoscha/flink-1.4.0-rc3/ >> [3] https://dist.apache.org/repos/dist/release/flink/KEYS >> [4] https://repository.apache.org/content/repositories/orgapacheflink-1141 >> [5] https://git-wip-us.apache.org/repos/asf?p=flink.git;a=tag;h= >> 8fb9635dd2e64dbb20887c84f646f02034b57cb1 >> [6] https://github.com/apache/flink-web/pull/95 >> [7] https://docs.google.com/document/d/1cOkycJwEKVjG_ >> onnpl3bQNTq7uebh48zDtIJxceyU2E/edit?usp=sharing >> >> Pro-tip: you can create a settings.xml file with these contents: >> >> <settings> >> <activeProfiles> >> <activeProfile>flink-1.4.0</activeProfile> >> </activeProfiles> >> <profiles> >> <profile> >> <id>flink-1.4.0</id> >> <repositories> >> <repository> >> <id>flink-1.4.0</id> >> <url> >> https://repository.apache.org/content/repositories/ >> orgapacheflink-1141/ >> </url> >> </repository> >> <repository> >> <id>archetype</id> >> <url> >> https://repository.apache.org/content/repositories/ >> orgapacheflink-1141/ >> </url> >> </repository> >> </repositories> >> </profile> >> </profiles> >> </settings> >> >> And reference that in you maven commands via --settings >> path/to/settings.xml. This is useful for creating a quickstart based on the >> staged release and for building against the staged jars.
