+1 (binding)

- I scanned the changes
- Run some example table programs

Looks good from my side.

Regards,
Timo


Am 2/14/18 um 5:46 PM schrieb Aljoscha Krettek:
+1 (binding)

  - I checked the signatures and hashes
  - I ran a cluster and tried some example programs
  - I checked the list of all changes: we're good, legally, and the other 
changes also all look good

The only thing I'm not sure about is the Network Buffer changes but I don't 
think they make things worse.

Best,
Aljoscha

On 13. Feb 2018, at 19:19, Fabian Hueske <fhue...@gmail.com> wrote:

Hi Alex,

FLINK-6352 seems to be an improvement / new feature.
These are included in minor releases like 1.5.0 but not in bug fix releases
such as 1.4.1.

Best, Fabian

2018-02-13 19:08 GMT+01:00 Alexandru Gutan <alex.guta...@gmail.com>:

Hi everyone,

Is [FLINK-6352] [kafka] Timestamp-based offset configuration for
FlinkKafkaConsumer <https://github.com/apache/flink/pull/5282> going to
make it into 1.4.1? Or it's left for 1.5?

Best,
Alex.

On 13 February 2018 at 19:05, Fabian Hueske <fhue...@gmail.com> wrote:

Hi,

I check the diff between Flink 1.4.0 and Flink 1.4.1-RC1 for
added/changed
dependencies.
I only found a version update of the Snappy dependency. Both, the
previous
and the new version, are ASL so this is fine.

The signatures and hashes are OK.
I also built the binary release and found no issues, i.e., mvn
-DskipTests
clean install finished successfully.

+1 (binding) to release RC1

@Gordon, thanks for taking care of the release!

Best, Fabian

2018-02-10 15:21 GMT+01:00 Tzu-Li (Gordon) Tai <tzuli...@apache.org>:

Hi everyone,

Please review and vote on release candidate #1 for Flink 1.4.1, as
follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)

The complete staging area is available for your review, which includes:
* JIRA release notes [1],
* the official Apache source release and binary convenience releases to
be
deployed to dist.apache.org [2], which are signed with the key with
fingerprint 1C1E2394D3194E1944613488F320986D35C33D6A [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag “release-1.4.1-rc1” [5],
* website pull request listing the new release [6].
* A complete list of all new commits in release-1.4.1-rc1, since
release-1.4.0 [7]

The vote will be open for at least 72 hours.
Please test the release and vote for the release candidate before
Wednesday (February 14th), 7pm CET.
It is adopted by majority approval, with at least 3 PMC affirmative
votes.
Thanks,
Gordon

[1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?
projectId=12315522&version=12342212
[2] http://people.apache.org/~tzulitai/flink-1.4.1-rc1/
[3] https://dist.apache.org/repos/dist/release/flink/KEYS
[4] https://repository.apache.org/content/repositories/
orgapacheflink-1145
[5] https://git-wip-us.apache.org/repos/asf?p=flink.git;a=commit;h=
dbab73e5d097518838283a7a4f056cca0ac3f9a5
[6] https://github.com/apache/flink-web/pull/101

[7]
* dbab73e5d0 - Commit for release 1.4.1 (17 hours ago)
* beff62d2e6 - [FLINK-8571] [DataStream] Introduce utility function
that
reinterprets a data stream as keyed stream (backport from 1.5 branch)
(17
hours ago)
* 33ebc85c28 - [FLINK-8362] [elasticsearch] Further improvements for
Elasticsearch connector shading (2 days ago)
* 0c53e798cb - [FLINK-8362][elasticsearch] shade all dependencies (2
days
ago)
* 5f9e367be6 - [FLINK-7760] Fix deserialization of NFA state in CEP
library (3 days ago)
* 82f3957811 - [FLINK-8275] [security, yarn] Remove test-specific code
path in YarnTaskManagerRunner (4 days ago)
* 20146652ba - [FLINK-8275] [security, yarn] Fix keytab local path in
YarnTaskManagerRunner (4 days ago)
* fb1e24e25e - [FLINK-8421] [test] Increase MAX_MEM_STATE_SIZE and Akka
framesize in AbstractEventTimeWindowCheckpointingITCase (4 days ago)
* 71d682eb7f - [FLINK-8421] [DataStream] Make timer serializers
reconfigurable on restore (4 days ago)
* 93d514e628 - [FLINK-8421] [core] Introduce
PostVersionedIOReadableWritable
(4 days ago)
* 319d510174 - [FLINK-8421] [core] Allow InstantiationUtil.
deserializeObject()
to use FailureTolerantObjectInputStream (4 days ago)
* 1f81f6acf4 - [FLINK-8421] [DataStream, tests] Add WindowOperator
migration test for Kryo-serialized window keys (4 days ago)
* e41300d5a9 - [hotfix] [test] Remove stale savepoint files no longer
used
by migration tests (4 days ago)
* f68fe3ee65 - [FLINK-8472] [tests] Extend
AbstractOperatorRestoreTestBas
es
for Flink 1.4 (4 days ago)
* 6f4116fe53 - [FLINK-8472] [fs, test] Extend
BucketingSinkMigrationTest
for Flink 1.4 (4 days ago)
* 8d910963fc - [FLINK-8472] [fs, test] Extend
ContinuousFileProcessingMigrationTest for Flink 1.4 (4 days ago)
* da47bd2ac8 - [FLINK-8472] [kafka, test] Extend
FlinkKafkaConsumerBaseMigrationTest for Flink 1.4 (4 days ago)
* 8cef78878d - [FLINK-8472] [kinesis, test] Extend
FlinkKinesisConsumerMigrationTest for Flink 1.4 (4 days ago)
* 83b9727dcc - [FLINK-8472] [DataStream, test] Extend
StatefulJobSavepointMigrationITCase for Flink 1.4 (4 days ago)
* 2ada8567e8 - [FLINK-8472] [DataStream, test] Refactor
StatefulJobSavepointFrom*MigrationITCase to single ITCase (4 days ago)
* 4fc14ccf7c - [FLINK-8472] [scala, test] Extend
StatefulJobSavepointMigrationITCase for Flink 1.4 (4 days ago)
* 4af0b59968 - [FLINK-8472] [DataStream, test] Extend
WindowOperatorMigrationTest for Flink 1.4 (4 days ago)
* 9276ee51aa - [hotfix] [kinesis] Use ArrayList for faster shard state
updates (4 days ago)
* 7884a4f749 - [FLINK-8484] [kinesis] Use an equivalence wrapper around
restored StreamShardMetadatas to bypass out-of-sync shard infos (4 days
ago)
* f887575f88 - [hotfix] [kinesis, test] Use real test classes instead
of
Mockito in FlinkKinesisConsumerMigrationTest (4 days ago)
* 426cf46970 - [FLINK-8484] [kinesis] Synchronize local shard
metainfo’s
on restore (4 days ago)
* ca1e525c5c - [FLINK-8398] [kinesis, tests] Stabilize flaky
KinesisDataFetcherTests (4 days ago)
* 6922e4c6b6 - [FLINK-8398] [kinesis, tests] Cleanup confusing
implementations in KinesisDataFetcherTest and related classes (4 days
ago)
* 0ad82b39ad - [hotfix][connectors] Fix log format strings (4 days ago)
* 432273aa96 - [FLINK-8419] [kafka] Register metrics for dynamically
discovered Kafka partitions (4 days ago)
* e5ac4b08f7 - [FLINK-8419] [kafka] Move consumer metric group
registration to FlinkKafkaConsumerBase (4 days ago)
* a951852fb4 - [hotfix] [kafka] Make AbortedReassignmentException a
static
class (4 days ago)
* 08163009e4 - [FLINK-8409] [kafka] Fix offset committing race
condition
in KafkaConsumerThread (4 days ago)
* c9322661ea - [FLINK-8559][RocksDB] Release resources if snapshot
operation fails (4 days ago)
* 33efaf74a1 - [FLINK-8561] [cep] Fix SharedBuffer.removeEdges to use
.equals(). (5 days ago)
* a35b37a412 - [hotfix] [cep] SharedBuffer refactoring. (5 days ago)
* 624131be3f - [FLINK-8242] [table] RexProgramExtractor only translates
literals of known types. (5 days ago)
* 19fcd5ebad - [FLINK-8242] [orc] Fix predicate translation if literal
is
not Serializable. (5 days ago)
* e5c1261919 - [FLINK-8243] [orc] OrcTableSource reads input path
recursively by default. (5 days ago)
* dfa050c01a - [FLINK-8489][ES] Prevent side-effects when modifying
user-config (8 days ago)
* 4219572a87 - Revert “[FLINK-8411] [State Backends]
HeapListState#add(null) will wipe out entire list state” (10 days ago)
* 110b86dd20 - [FLINK-8230] [orc] Fix NPEs when reading nested columns.
(10 days ago)
* 0cc0572c44 - [FLINK-8496][metrics] Create missing “Network” group (10
days ago)
* 14aabf82cf - [hotfix][docs] Fix Scala code example in Controlling
Latency section (12 days ago)
* 09edf6a628 - [FLINK-8485] [client] Unblock JobSubmissionClientActor#
tryToSubmitJob
(2 weeks ago)
* fb088bc134 - [FLINK-7949] Add unit test for AsyncWaitOperator
recovery
with full queue (2 weeks ago)
* a2198b0471 - [FLINK-7949] Make AsyncWaitOperator recoverable also
when
queue is full (2 weeks ago)
* 38278ebefe - [FLINK-8352] [web-dashboard] Report error on jar
submission
failure (2 weeks ago)
* eb6380901e - [FLINK-8406] [bucketing sink] Fix proper access of
Hadoop
File Systems (2 weeks ago)
* 4d1ba45e78 - [FLINK-8466] [runtime] Make sure ErrorInfo references no
user-defined classes. (2 weeks ago)
* a8ea1698f4 - [hotfix] [build] Converge Kryo dependency (2 weeks ago)
* 15cb057bff - [FLINK-8499] [core] Force Kryo to be parent-first
loaded.
(2 weeks ago)
* da8446ee5d - [hotfix] [build] Fix diverging snappy versions. (2 weeks
ago)
* c701a335be - [hotfix] [build] Print cache info (2 weeks ago)
* 77df20bc50 - [FLINK-8433] [doc] Remove ununsed CheckpointedRestoring
interface (2 weeks ago)
* e4d7ea2641 - [FLINK-8079][tests] Stop end-to-end test execution after
first failure (2 weeks ago)
* 20be204b96 - [FLINK-8473][webUI] Improve error behavior of
JarListHandler (2 weeks ago)
* df05261723 - [FLINK-8411] [State Backends] HeapListState#add(null)
will
wipe out entire list state (3 weeks ago)
* aa5e491804 - [FLINK-8325] [table] Fix COUNT(*) and COUNT(1). (3 weeks
ago)
* bfe3ff07c3 - [FLINK-8355] [table] Remove
DataSetAggregateWithNullValues
Rule.
(3 weeks ago)
* 537552267a - [FLINK-8461] [build] Adjust logger configurations for
shaded Netty classnames (3 weeks ago)
* 0677f08b8f - [FLINK-8455] [core] Make ‘org.apache.hadoop.’ a
‘parent-first’ classloading pattern. (3 weeks ago)
* 0deaee835c - [hotfix] [docs] Fix typos (3 weeks ago)
* c91544d140 - [hotfix] [kafka] Remove stale comment on publishing
procedures of AbstractFetcher (4 weeks ago)
* c4bfc7de36 - [FLINK-8306] [kafka, tests] Fix mock verifications on
final
method (4 weeks ago)
* 968683f153 - [FLINK-8296] [kafka] Rework FlinkKafkaConsumerBaseTest
to
not rely on Java reflection (4 weeks ago)
* b7f8a5a2b0 - [hotfix] Fix typo in AbstractMetricGroup.java (4 weeks
ago)
* ae00cad38c - [hotfix] [doc] Fixed doc typo in DataStream API (4 weeks
ago)
* b607a8b95d - [FLINK-6951] [kinesis] Shade httpcomponents dependency
for
Kinesis connector (4 weeks ago)
* b32ac3aaf9 - [FLINK-8226] [cep] Dangling reference generated after
NFA
clean up timed out SharedBufferEntry (4 weeks ago)
* 71ede3992a - [FLINK-8371][network] always recycle Buffers when
releasing
SpillableSubpartition (4 weeks ago)
* a316989e5d - [FLINK-7499][io] also let AsynchronousBufferFileWriter#
writeBlock()
recycle the buffer in case of failures (4 weeks ago)
* 2c667dea8e - [hotfix] only update buffer statistics in
SpillableSubpartition#add() if successful (4 weeks ago)
* 9398dafae6 - [hotfix] add some more buffer recycling checks in
SpillableSubpartitionTest (4 weeks ago)
* 6f50ed256a - [FLINK-8320][docs] Clarify that only Java 8 is supported
(5
weeks ago)
* 951d1b94d9 - [hotfix][docs][metrics] Fix Threads.Count metric
reference
(5 weeks ago)
* 2f6e001172 - [hotfix][docs] Fix DataStream iterations documentation
(5
weeks ago)
* 78e3405bec - [FLINK-8200][tests] Use TemporaryFolder in
RocksDBAsyncSnapshotTest (5 weeks ago)
* 74135c9db1 - [FLINK-8283] [kafka] Stabalize
FlinkKafkaConsumerBaseTest::testScaleUp()
(5 weeks ago)
* f462f77194 - [hotfix] [kafka] Add serialVersionUID to
FlinkKafkaProducer010 (5 weeks ago)
* 16a49de3f6 - [hotfix] [kafka] Fix stale Javadoc link in
FlinkKafkaProducer09 (5 weeks ago)
* 24d449353e - [hotfix] [kafka] Properly deprecate
FlinkKafkaProducer010Configuration (5 weeks ago)
* 10f1acf923 - [FLINK-8260] [kafka] Reorder deprecated / regular
constructors of FlinkKafkaProducer010 (5 weeks ago)
* 71974895da - [FLINK-8287] [kafka] Improve Kafka producer Javadocs /
doc
to clarify partitioning behaviour (5 weeks ago)
* c454ee3fa9 - [FLINK-8260] [kafka] Fix usage of deprecated
instantiation
methods in FlinkKafkaProducer docs (5 weeks ago)
* 1e637c54c2 - [FLINK-8116] [DataStream] Provide proper checkpointed
source function example in Javadocs (5 weeks ago)
* 6884ce98f3 - [FLINK-8116] [DataStream] Fix stale comments referring
to
Checkpointed interface (5 weeks ago)
* 4b2178677e - [FLINK-8346][docs] add v4 signature workaround for
manual
S3 setups (5 weeks ago)
* 1c7a7fa706 - [FLINK-8331][core] FieldParser do not correctly set
EMPT_COLUMN error state. (5 weeks ago)
* e7395efece - [FLINK-8323] [table] Fix modulo scalar function bug (5
weeks ago)
* ff8b2098b2 - [hotfix] [docs] Fix Scala code snippets in docs. (5
weeks
ago)
* 5cf0f57b99 - [hotfix] [docs] Remove duplicated ‘program’ in docs/dev/
api_concepts.md (5 weeks ago)
* 87d8dc1b0a - [FLINK-8265] Missing jackson dependency for flink-mesos
(5
weeks ago)
* 96051e516b - [FLINK-5506] [gelly] Fix CommunityDetection
NullPointerException (6 weeks ago)
* e42182d40b - [FLINK-8278] [docs] Fix Scala examples of metrics docs
(var
initialization). (7 weeks ago)
* 47c067a592 - [FLINK-8301][table] Support Unicode in codegen for
TableAPI
&& SQL (7 weeks ago)
* 7e497f744a - [FLINK-8295] [cassandra] [build] Properly shade netty
for
the datastax driver (7 weeks ago)
* f638deddb7 - [hotfix] [doc] Fix typo in TaskManager and
EnvironmentInformation doc (8 weeks ago)
* dbbaa9a4a7 - [FLINK-8249] [kinesis] Fix setting region on
KinesisProducerConfiguration (8 weeks ago)
* 0e27e20886 - [hotfix] [javadoc] Fix typo in
StreamExecutionEnvironment
javadoc (8 weeks ago)
* 57de25d895 - [FLINK-8264] [core] Add ‘scala.’ to the ‘parent-first’
classloading patterns. (8 weeks ago)
* 18efbea671 - [FLINK-8263] [quickstarts] Correctly set ‘flink-core’ to
provided in Scala Quickstart pom.xml (8 weeks ago)
* d84e215136 - [hotfix] [quickstarts] Fix indentation in Java
Quickstart
pom.xml (8 weeks ago)
* dcd3e3ab4d - [hotfix] [quickstarts] Exclude not only slf4j api, but
also
bridges (8 weeks ago)
* a4b401c8eb - [FLINK-8261] [quickstarts] Fix typos in exclusion
patterns.
(8 weeks ago)
* 6981412f73 - [hotfix][javadocs] Clarify replacement for deprecated
FoldingState (8 weeks ago)
* d94bd7cbe5 - [hotfix] [docs] Correct version in _config.yml (8 weeks
ago)
* 897e6a7a89 - [FLINK-8235][build] Spotbugs exclusion file path now
absolute (9 weeks ago)
* b8f1744b54 - [FLINK-8145][tests] fix various IOManagerAsync instances
not being shut down (9 weeks ago)
* 0b024aad17 - [hotfix][javadoc] Fix typo in StreamElement javadoc (9
weeks ago)
* f00e7297a5 - Update 1.4.0 doc to “stable” (9 weeks ago)
* 2435fe9091 - [hotfix] [docs] Upgrade Scala version to 2.11 (9 weeks
ago)
* 9b63cbacec - [FLINK-7880][QS] Wait for proper resource cleanup after
each ITCase. (9 weeks ago)
* 415b74ce17 - [FLINK-7974][QS] Wait for QS abstract server to
shutdown.
(9 weeks ago)
* 68b5a61aab - [FLINK-7975][QS] Wait for QS client to shutdown. (9
weeks
ago)



Reply via email to