Yes, Till, I am sorry that I did not keep the exception information before re-run the CI. When I started CI again, the problem has disappeared. I will continue to pay attention to this issue. I will keep the log when it happens again. I agree that this issue is not the release blocker !
Best, Jincheng Till Rohrmann <trohrm...@apache.org> 于2018年11月9日周五 下午7:48写道： > Thanks for letting me know Jincheng. I tried to reproduce the problem but I > was so far not successful. I will continue the investigation. For the > moment I would not block the release on that. > > Cheers, > Till > > On Thu, Nov 8, 2018 at 7:19 PM jincheng sun <sunjincheng...@gmail.com> > wrote: > > > Hi Till, > > > > Today when I do the CI before merge code, I find a instability test case: > > JobManagerHAProcessFailureRecoveryITCase.testDispatcherProcessFailure > test > > fail. > > I'm not sure if this is issue should blocking the release 1.7, but I > think > > it's best to find the cause and fix it before releasing 1.7. > > The corresponding JIRA issue is: > > https://issues.apache.org/jira/browse/FLINK-10819 > > > > Thanks, > > Jincheng > > > > Till Rohrmann <trohrm...@apache.org> 于2018年11月7日周三 下午10:13写道： > > > > > I hereby cancel the release vote because of the Scala suffix problems. > I > > > will create the next RC in the next days. Until then, please continue > > > testing with the current release candidate. > > > > > > Cheers, > > > Till > > > > > > On Wed, Nov 7, 2018 at 2:39 PM Till Rohrmann <trohrm...@apache.org> > > wrote: > > > > > > > Thanks for spotting and addressing the Scala problem Chesnay. The > > > > corresponding JIRA issue is > > > > https://issues.apache.org/jira/browse/FLINK-10811. > > > > > > > > Cheers, > > > > Till > > > > > > > > On Wed, Nov 7, 2018 at 12:36 PM Chesnay Schepler <ches...@apache.org > > > > > > wrote: > > > > > > > >> This isn't quite correct (as test-scoped dependencies are not > > > >> transitive, but all compile dependencies still are, even for the > > > >> test-jar). > > > >> > > > >> But effectively this means we don't need additional rules for > > test-jars > > > >> as compile dependencies already have to be taken care of separately > > from > > > >> tests anyway. > > > >> > > > >> I'll open JIRA for the hcatalog issue and scan through the remaining > > > >> modules for other violations. > > > >> > > > >> On 07.11.2018 11:46, Aljoscha Krettek wrote: > > > >> > I looked into this issue and my conclusion was that test-jars > don't > > > >> pull in transitive dependencies when you depend on them. I verified > > this > > > >> with an example maven project where I also verified that a test-jar > > > built > > > >> with Scala 2.12 works on a project that uses Scala 2.11. > > > >> > > > > >> > On the hcatalog connector: This is unfortunate and we should add > the > > > >> Scala suffix here. It's unfortunate since flink-hcatalog and > > > >> flink-hadoop-compatibility wouldn't have to have a Scala suffix, > they > > > don't > > > >> depend on any other suffixed dependencies, they only reason is that > > they > > > >> themselves contain Scala code. This could have been avoided by > putting > > > the > > > >> Scala code in a separate module. > > > >> > > > > >> > Aljoscha > > > >> > > > > >> >> On 7. Nov 2018, at 10:55, Chesnay Schepler <ches...@apache.org> > > > wrote: > > > >> >> > > > >> >> What was the conclusion in regards to modules requiring a > > > scala-suffix > > > >> if their test-jar depends on scala-infected modules? (Which > basically > > > >> affects all modules) > > > >> >> > > > >> >> Beyond that, the hcatalog connector has a dependency on > > > >> flink-hadoop-compatibility_2.12, and should thus also have a scala > > > suffix. > > > >> There are probably other instances as well. > > > >> >> > > > >> >> On 05.11.2018 22:26, Till Rohrmann wrote: > > > >> >>> Hi everyone, > > > >> >>> Please review and vote on the release candidate #1 for the > version > > > >> 1.7.0, > > > >> >>> as follows: > > > >> >>> [ ] +1, Approve the release > > > >> >>> [ ] -1, Do not approve the release (please provide specific > > > comments) > > > >> >>> > > > >> >>> > > > >> >>> The complete staging area is available for your review, which > > > >> includes: > > > >> >>> * JIRA release notes [1], > > > >> >>> * the official Apache source release and binary convenience > > releases > > > >> to be > > > >> >>> deployed to dist.apache.org [2], which are signed with the key > > with > > > >> >>> fingerprint 1F302569A96CFFD5 [3], > > > >> >>> * all artifacts to be deployed to the Maven Central Repository > > [4], > > > >> >>> * source code tag "release-1.7.0-rc1" [5], > > > >> >>> > > > >> >>> Please use this document for coordinating testing efforts: [6] > > > >> >>> > > > >> >>> The vote will be open for at least 72 hours. It is adopted by > > > majority > > > >> >>> approval, with at least 3 PMC affirmative votes. > > > >> >>> > > > >> >>> Thanks, > > > >> >>> Till > > > >> >>> > > > >> >>> [1] > > > >> >>> > > > >> > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12343585 > > > >> >>> [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.7.0/ > > > >> >>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > >> >>> [4] > > > >> > > https://repository.apache.org/content/repositories/orgapacheflink-1191 > > > >> >>> [5] https://github.com/apache/flink/tree/release-1.7.0-rc1 > > > >> >>> [6] > > > >> >>> > > > >> > > > > > > https://docs.google.com/document/d/12JY_Xyy6umGR1vvrBFbqtDvf6ZdAYSAiljchrnsMUZs/edit?usp=sharing > > > >> >>> > > > >> >>> Pro-tip: you can create a settings.xml file with these contents: > > > >> >>> > > > >> >>> <settings> > > > >> >>> <activeProfiles> > > > >> >>> <activeProfile>flink-1.7.0</activeProfile> > > > >> >>> </activeProfiles> > > > >> >>> <profiles> > > > >> >>> <profile> > > > >> >>> <id>flink-1.7.0</id> > > > >> >>> <repositories> > > > >> >>> <repository> > > > >> >>> <id>flink-1.7.0</id> > > > >> >>> <url> > > > >> >>> > > > >> >>> > > > >> > > https://repository.apache.org/content/repositories/orgapacheflink-1191/ > > > >> >>> </url> > > > >> >>> </repository> > > > >> >>> <repository> > > > >> >>> <id>archetype</id> > > > >> >>> <url> > > > >> >>> > > > >> >>> > > > >> > > https://repository.apache.org/content/repositories/orgapacheflink-1191/ > > > >> >>> </url> > > > >> >>> </repository> > > > >> >>> </repositories> > > > >> >>> </profile> > > > >> >>> </profiles> > > > >> >>> </settings> > > > >> >>> > > > >> >>> And reference that in you maven commands via --settings > > > >> >>> path/to/settings.xml. This is useful for creating a quickstart > > based > > > >> on the > > > >> >>> staged release and for building against the staged jars. > > > >> >>> > > > >> > > > > >> > > > >> > > > > > >
