I prefer alternative 2 as the first is rather ambiguous. The emojis seem
unnecessary, the approved label could be shorted to "Approved"; the
review prefix isn't necessary here imo.
I would stick the green checkmarks as this is consistent with Travis.
As another request, we may want to ignore flinkbot comments if they come
from the person opening the PR.
(Yes, there's already a precedence)
On 19.02.2019 15:49, Robert Metzger wrote:
Thank you all for the proposals!
I've implemented most of the suggestions already, I hope to deploy it soon
to the repo
For the long label names:
I agree with Stephan that they are pretty long at the moment.
*Alternative 1:*
review=☐☐☐☐
review=☐☐☐☑
review=☐☐☑☑
review=☐☑☑☑
review=✅
*Alternative 2:*
review=description
review=consensus
review=architecture
review=quality
review=approved ✅
We could also add a ( ❓) emoji to alternative 2, but I found it looks ugly.
I lean towards alternative 2.
@jincheng sun <sunjincheng...@gmail.com> I could actually not find
appropriate emojis with the colors you've proposed. The only thing that has
a nice range of colors are hearts, but I think that's not a good fit in our
case :)
On Fri, Feb 15, 2019 at 12:59 PM Chesnay Schepler <ches...@apache.org>
wrote:
The bot could check that the PR title to starts with [FLINK-X] or [hotfix].
On 13.02.2019 10:29, Robert Metzger wrote:
Hey all,
the flinkbot has been active for a week now, and I hope the initial
hiccups
have been resolved :)
I wanted to start this as a permanent thread to discuss problems and
improvements with the bot.
*So please post here if you have questions, problems or ideas how to
improve it!*
