Hi,

This would definitely be beneficial. And yes, we would have to keep the current 
constructors for at least one release marked as @Deprecated.

Piotrek

> On 4 Mar 2019, at 08:49, Александр <[email protected]> wrote:
> 
> Hi, devs. I recently joined the community and I'm trying to understand the
> project module by module. I've noticed that in FlinkKafkaProducer (
> *https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer.java
> <https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer.java>*
> )
> we have about ~ 8 constructors. Maybe we can use builder pattern here? It
> seems the better solution. However, we have to keep our constructors for
> backward compatibility (but mark it deprecated I think).
> 
> What do you think about this idea? I would like to focus on it.
> 
> BR,
> Aleksandr Salatich

Reply via email to