I'm sorry, but if these issues are only fixed later anyway I see no
reason to run these tests on each PR. We're just adding noise to each PR
that everyone will just ignore.
I'm curious as to the benefit of having this directly in Flink; why
aren't the ARM builds run outside of the Flink project, and fixes for it
provided?
It seems to me like nothing about these arm builds is actually handled
by the Flink project.
On 26/08/2019 03:43, Xiyuan Wang wrote:
Thanks for Stephan to bring up this topic.
The package build jobs work well now. I have a simple online demo which is
built and ran on a ARM VM. Feel free to have a try[1].
As the first step for ARM support, maybe it's good to add them now.
While for the next step, the test part is still broken. It relates to some
points we find:
1. Some unit tests are failed[1] by Java coding. These kind of failure can
be fixed easily.
2. Some tests are failed by depending on third part libaraies[2]. It
includes frocksdb, MapR Client and Netty. They don't have ARM release.
a. Frocksdb: I'm testing it locally now by `make check_some` and `make
jtest` similar with its travis job. There are 3 tests failed by `make
check_some`. Please see the ticket for more details. Once the test pass,
frocksdb can release ARM package then.
b. MapR Client. This belongs to MapR company. At this moment, maybe we
should skip MapR support for Flink ARM.
c. Netty. Actually Netty runs well on our ARM machine. We will ask
Netty community to release ARM support. If they do not want, OpenLab will
handle a Maven Repository for some common libraries on ARM.
For Chesnay's concern:
Firstly, OpenLab team will keep maintaining and fixing ARM CI. It means
that once build or test fails, we'll fix it at once.
Secondly, OpenLab can provide ARM VMs to everyone for reproducing and
testing. You just need to creat a Test Request issue in openlab[1]. Then
we'll create ARM VMs for you, you can login and do the thing you want.
Does it make sense?
[1]: http://114.115.168.52:8081/#/overview
[1]: https://issues.apache.org/jira/browse/FLINK-13449
https://issues.apache.org/jira/browse/FLINK-13450
[2]: https://issues.apache.org/jira/browse/FLINK-13598
[3]: https://github.com/theopenlab/openlab/issues/new/choose
Chesnay Schepler <ches...@apache.org> 于2019年8月24日周六 上午12:10写道：
I'm wondering what we are supposed to do if the build fails?
We aren't providing and guides on setting up an arm dev environment; so
reproducing it locally isn't possible.
On 23/08/2019 17:55, Stephan Ewen wrote:
Hi all!
As part of the Flink on ARM effort, there is a pull request that
triggers a
build on OpenLabs CI for each push and runs tests on ARM machines.
Currently that build is roughly equivalent to what the "core" and "tests"
profiles do on Travis.
The result will be posted to the PR comments, similar to the Flink Bot's
Travis build result.
The build currently passes :-) so Flink seems to be okay on ARM.
My suggestion would be to try and add this and gather some experience
with
it.
The Travis build results should be our "ground truth" and the ARM CI
(openlabs CI) would be "informational only" at the beginning, but helping
us understand when we break ARM support.
You can see this in the PR that adds the openlabs CI config:
https://github.com/apache/flink/pull/9416
Any objections?
Best,
Stephan
