Hi Jark, Majority of the changes make sense to me. I think they will be helpful for the users. I have a slight concern about the
kafka's connector.properties property :) . I wonder if we should have them under a single key: connector.properties: `zookeeper.connect`:`localhost:2181`;`bootstrap.servers`:`localhost:9092` As far as I understand it, these are mostly the properties that are forwarded straight to the underlying KafkaClient. Such properties are mostly defined and documented by the kafka itself rather than flink. They might also follow a different formatting scheme than we have for our properties. Moreover how do we decide which properties are put into the Properties object and which are not? I would be happy to hear what others think about that part, as I am not convinced myself about that part. Best, Dawid On 13/11/2019 13:22, Jark Wu wrote: > Hi everyone, > > Connector properties is a very basic component which is used to construct a > connector table via YAML, descriptor API, or DDL. It is also the > serialization representation when persisting into catalog. However, we have > encountered some problems when using connector properties, especially in > DDL. This FLIP is aiming to solve following two issues: > > - FLINK-14645: Data types defined in DDL loses precision and nullability > when converting to properties. > - FLINK-14649: Some properties structure is hard to define in DDL, e.g. > List and Map structure. > > This FLIP proposes new properties to represent data types in schema and to > flatten properties in existing connectors. > > FLIP-86: > https://docs.google.com/document/d/14MlXFB45NUmUtesFMFZFjFhd4pqmYamxbfNwUPrfdL4/edit# > > Thanks for any feedback! > > Best, > Jark >
signature.asc
Description: OpenPGP digital signature
