+1 from my side. Best, Jark
On Sat, 23 Nov 2019 at 16:04, Xingcan Cui <xingc...@gmail.com> wrote: > Thanks for driving this, Dawid. > > I’m +1 on it. > > One minor suggestion: I think it’s better to override the `equals()` and > `hashCode()` methods for `KeyConstraint`. > > Thanks, > Xingcan > > > On Nov 23, 2019, at 2:40 AM, Jingsong Li <jingsongl...@gmail.com> wrote: > > > > +1 thanks dawid for driving this. > > > > Best > > Jingsong Lee > > > > Timo Walther <twal...@apache.org>: > > > >> +1 > >> > >> Thanks, > >> Timo > >> > >> > >> On 23.11.19 00:28, Xuefu Z wrote: > >>> +1 > >>> > >>> On Fri, Nov 22, 2019 at 5:31 AM Kurt Young <ykt...@gmail.com> wrote: > >>> > >>>> +1 > >>>> > >>>> Best, > >>>> Kurt > >>>> > >>>> > >>>> On Fri, Nov 22, 2019 at 8:51 PM Dawid Wysakowicz < > >> dwysakow...@apache.org> > >>>> wrote: > >>>> > >>>>> Hi everyone, > >>>>> > >>>>> I would like to start a vote on FLIP-87. > >>>>> > >>>>> Please vote for the following design document: > >>>>> > >>>> > >> > https://cwiki.apache.org/confluence/display/FLINK/FLIP+87%3A+Primary+key+constraints+in+Table+API > >>>>> > >>>>> The discussion can be found at: > >>>>> > >>>> > >> > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Primary-keys-in-Table-API-td35138.html > >>>>> This voting will be open for at least 72 hours. > >>>>> > >>>>> Best, > >>>>> Dawid > >>>>> > >>>>> > >>>> > >>> > >>> > >> > >> -- > > Best, Jingsong Lee > >