Thanks Jingsong for bring up this discussion ~
After reviewing FLIP-63, it seems that we have made a conclusion for the syntax
- INSERT OVERWRITE ...
- INSERT INTO … PARTITION
Which means that they should not have the Hive dialect limitation, so I’m
inclined that the behaviors for SQL-CLI is unexpected, or a “bug” that need to
fix.
We did not make a conclusion for the syntax:
- CREATE TABLE … PARTITIONED BY ...
Which means that the behavior of it is under-discussion, so it is okey to be
without the HIVE dialect limitation, we do not actually have any table
sources/sinks that support such a DDL so for current code base, users should
not be influenced by the behaviors change.
So I’m
+1 to remove the hive dialect limitations for INSERT OVERWRITE and INSERT
PARTITION
+0 to add yaml dialect conf to SQL-CLI because FLIP-89 is not finished yet, we
better do this until FLIP-89 is resolved.
Best,
Danny Chan
在 2019年12月11日 +0800 PM5:29，Jingsong Li <jingsongl...@gmail.com>，写道：
> Hi Dev,
>
> After cutting out the branch of 1.10, I tried the following functions of
> SQL-CLI and found that it does not support:
> - insert overwrite
> - PARTITION (partcol1=val1, partcol2=val2 ...)
> The SQL pattern is:
> INSERT { INTO | OVERWRITE } TABLE tablename1 [PARTITION (partcol1=val1,
> partcol2=val2 ...) select_statement1 FROM from_statement;
> It is a surprise to me.
> The reason is that we only allow these two grammars in hive dialect. And
> SQL-CLI does not have an interface to switch dialects.
>
> Because it directly hinders the SQL-CLI's insert syntax in hive integration
> and seriously hinders the practicability of SQL-CLI.
> And we have introduced these two grammars in FLIP-63 [1] to Flink.
> Here are my question:
> 1.Should we remove hive dialect limitation for these two grammars?
> 2.Should we fix this in 1.10?
>
> [1]
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-63%3A+Rework+table+partition+support
>
> Best,
> Jingsong Lee
