Thanks for open this FLIP and summarize the current state of Dockerfiles, Andrey! +1 for this idea.
I have some minor comments / questions: - Regarding the flink_docker_utils#install_flink function, I think it should also support build from local dist and build from a user-defined archive. - It seems that the install_shaded_hadoop could be an option of install_flink. - Should we support JAVA 11? Currently, most of the docker file based on JAVA 8. - I do not understand how to set config options through "flink_docker_utils configure"? Does this step happen during the image build or the container start? If it happens during the image build, there would be a new image every time we change the config. If it just a part of the container entrypoint, I think there is no need to add a configure command, we could just add all dynamic config options to the args list of "start_jobmaster"/"start_session_jobmanager". Am I understanding this correctly? Best, Yangze Guo Best, Yangze Guo On Wed, Mar 4, 2020 at 5:34 PM Andrey Zagrebin <azagre...@apache.org> wrote: > > Hi All, > > If you have ever touched the docker topic in Flink, you > probably noticed that we have multiple places in docs and repos which > address its various concerns. > > We have prepared a FLIP [1] to simplify the perception of docker topic in > Flink by users. It mostly advocates for an approach of extending official > Flink image from the docker hub. For convenience, it can come with a set of > bash utilities and documented examples of their usage. The utilities allow > to: > > - run the docker image in various modes (single job, session master, > task manager etc) > - customise the extending Dockerfile > - and its entry point > > Eventually, the FLIP suggests to remove all other user facing Dockerfiles > and building scripts from Flink repo, move all docker docs to > apache/flink-docker and adjust existing docker use cases to refer to this > new approach (mostly Kubernetes now). > > The first contributed version of Flink docker integration also contained > example and docs for the integration with Bluemix in IBM cloud. We also > suggest to maintain it outside of Flink repository (cc Markus Müller). > > Thanks, > Andrey > > [1] > https://cwiki.apache.org/confluence/display/FLINK/FLIP-111%3A+Docker+image+unification
