Hi Chesnay, thanks for kicking this discussion off. I agree that deduplicating code is in general a good idea.
The main benefit seems to be that all modules inherit a log4j2-test.properties file and that this file allows to control the logging output for several modules. The main drawback I see is that it complicates the debugging process for our devs. If you want to debug a problem and need logging for this, then you have to know that there is a log4j2-test.properties file in flink-test-utils-junit which you can tweak. At the moment, it is quite straight forward as you simply go to the module which contains the test and check the resources folder. If we are ok with this drawback and document the change properly, then I'm fine with this change. Cheers, Till On Mon, Apr 6, 2020 at 12:24 PM Chesnay Schepler <ches...@apache.org> wrote: > Hello, > > I discovered a handy trick that would allow us to share a single > log4j2-test.properties across all modules. > > https://github.com/apache/flink/pull/11634 > > The file would exist in flink-test-utils-junit/src/main/resources, and > be used for all modules except the kafka connectors and yarn-tests > (because they have some custom requirements). > > This would mean the files can no longer go out of sync, utilities can be > shared more easily, and you wouldn't need to add a new properties file > to new modules (or older ones lacking one) during debugging. > > Overall I personally quite, but I have heard some concerns about > changing dev routines so I wanted to double-check what people think in > general. > >
