+1(binding) - built from source and run Streaming word count without unexpected information. - check the signatures, looks good!
BTW: I've added your PyPI account(carp84) as a maintainer role. Great job Yu! Best, Jincheng Hequn Cheng <he...@apache.org> 于2020年5月12日周二 上午9:49写道： > +1 (binding) > > - Go through all commits from 1.10.0 to 1.10.1 and spot no new license > problems. > - Built from source archive successfully. > - Travis e2e tests have passed. > - Signatures and hash are correct. > - Run SocketWindowWordCount on the local cluster and check web ui & logs. > - Install Python package and run Python WordCount example. > - Website PR looks good. > > Best, > Hequn > > On Mon, May 11, 2020 at 10:39 PM Ufuk Celebi <u...@apache.org> wrote: > > > +1 (binding) > > > > - checked release notes > > - verified sums and hashes > > - reviewed website PR > > - successfully built an internal Flink distribution based on the > 1.10.1-rc3 > > commit > > - successfully built internal jobs against the staging repo and deployed > > those jobs to a 1.10.1 job cluster on Kubernetes and tested checkpointing > > > > – Ufuk > > > > On Mon, May 11, 2020 at 11:47 AM Tzu-Li (Gordon) Tai < > tzuli...@apache.org> > > wrote: > > > > > > +1 (binding) > > > > > > Legal checks: > > > - checksum & gpg OK > > > - changes to Kinesis connector NOTICE files looks good > > > - built from source > > > > > > Downstream checks in flink-statefun: > > > - Built StateFun with Flink 1.10.1 + e2e tests enabled (mvn clean > install > > > -Prun-e2e-tests), builds and passes > > > - Previous issue preventing successful failure recovery when using the > > new > > > scheduler, is now fixed with this RC > > > > > > Cheers, > > > Gordon > > > > > > On Mon, May 11, 2020 at 2:47 PM Congxian Qiu <qcx978132...@gmail.com> > > wrote: > > > > > > > +1 (no-binding) > > > > > > > > - checksum & gpg ok > > > > - build from source OK > > > > - all pom files points to the same version OK > > > > - LICENSE OK > > > > - run demos OK > > > > Best, > > > > Congxian > > > > > > > > > > > > Dian Fu <dian0511...@gmail.com> 于2020年5月10日周日 下午10:14写道： > > > > > > > > > +1 (non-binding) > > > > > > > > > > - checked the dependency changes since 1.10.0 > > > > > 1) kafka was bumped from 0.10.2.1 to 0.10.2.2 for > > > > > flink-connector-kafka-0.10 and it has been reflected in the notice > > file > > > > > 2) amazon-kinesis-producer was bumped from 0.13.1 to 0.14.0 and > it > > has > > > > > been reflected in the notice file > > > > > 3) the dependencies com.carrotsearch:hppc, > > > > > com.github.spullara.mustache.java, > > org.elasticsearch:elasticsearch-geo > > > > and > > > > > org.elasticsearch.plugin:lang-mustache-client was bundled in the > jar > > of > > > > > flink-sql-connector-elasticsearch7 and it has been reflected in the > > > > notice > > > > > file > > > > > 4) influxdb-java was bumped from 2.16 to 2.17 and it has been > > reflected > > > > > in the notice file > > > > > - verified the checksum and signature > > > > > - checked that the PyFlink package could be pip installed > > > > > - have left a few minor comments on the website PR > > > > > > > > > > Regards, > > > > > Dian > > > > > > > > > > On Sat, May 9, 2020 at 12:02 PM Thomas Weise <t...@apache.org> > wrote: > > > > > > > > > > > Thanks for the RC! > > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > - repeated benchmark runs > > > > > > > > > > > > > > > > > > On Fri, May 8, 2020 at 10:52 AM Robert Metzger < > > rmetz...@apache.org> > > > > > > wrote: > > > > > > > > > > > > > Thanks a lot for creating another RC! > > > > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > > > - checked diff to last RC: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/flink/compare/release-1.10.1-rc2...release-1.10.1-rc3 > > > > > > > - kinesis dependency change is properly documented > > > > > > > - started Flink locally (on Java11 :) ) > > > > > > > - seems to be build off the specified commit > > > > > > > - ran example > > > > > > > - checked logs > > > > > > > - staging repo looks ok > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Thu, May 7, 2020 at 2:21 PM Yu Li <car...@gmail.com> wrote: > > > > > > > > > > > > > > > Hi everyone, > > > > > > > > > > > > > > > > Please review and vote on the release candidate #3 for > version > > > > > 1.10.1, > > > > > > as > > > > > > > > follows: > > > > > > > > [ ] +1, Approve the release > > > > > > > > [ ] -1, Do not approve the release (please provide specific > > > > comments) > > > > > > > > > > > > > > > > > > > > > > > > The complete staging area is available for your review, which > > > > > includes: > > > > > > > > * JIRA release notes [1], > > > > > > > > * the official Apache source release and binary convenience > > > > releases > > > > > to > > > > > > > be > > > > > > > > deployed to dist.apache.org [2], which are signed with the > key > > > > with > > > > > > > > fingerprint D8D3D42E84C753CA5F170BDF93C07902771AB743 [3], > > > > > > > > * all artifacts to be deployed to the Maven Central > Repository > > [4], > > > > > > > > * source code tag "release-1.10.1-rc3" [5], > > > > > > > > * website pull request listing the new release and adding > > > > > announcement > > > > > > > blog > > > > > > > > post [6]. > > > > > > > > > > > > > > > > The vote will be open for at least 72 hours. It is adopted by > > > > > majority > > > > > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > > > > > > > > > Thanks, > > > > > > > > Yu > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12346891 > > > > > > > > [2] > > https://dist.apache.org/repos/dist/dev/flink/flink-1.10.1-rc3/ > > > > > > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > > > > > > [4] > > > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheflink-1364/ > > > > > > > > [5] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/flink/commit/c5915cf87f96e1c7ebd84ad00f7eabade7e7fe37 > > > > > > > > [6] https://github.com/apache/flink-web/pull/330 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
