Yang Wang created FLINK-18171:
---------------------------------

             Summary: Do not take client side config options to cluster
                 Key: FLINK-18171
                 URL: https://issues.apache.org/jira/browse/FLINK-18171
             Project: Flink
          Issue Type: Improvement
          Components: Deployment / Kubernetes, Deployment / YARN
    Affects Versions: 1.11.0, 1.12.0
            Reporter: Yang Wang


Follow the discussion in this PR[1], some client side config options should not 
be taken into the cluster. Once it takes effect, it will cause some issue(e.g. 
FLINK-18149).

For K8s deployment, we have explicitly remove 
{{KubernetesConfigOptions.KUBE_CONFIG_FILE}} and 
{{DeploymentOptionsInternal.CONF_DIR}}. 

For Yarn deployment, we have at least two options 
{{DeploymentOptionsInternal.CONF_DIR}} and 
{{YarnConfigOptionsInternal.APPLICATION_LOG_CONFIG_FILE}} could be removed in 
client side.

 

Benefit from this, we could avoid some unexpected configuration loading or 
secret issues. Also we could avoid the logs in the jobmanager confusing the 
users since it is a client local path.
{code:java}
2020-06-05 14:38:38,656 INFO  
org.apache.flink.configuration.GlobalConfiguration           [] - Loading 
configuration property: $internal.deployment.config-dir, 
/home/danrtsey.wy/flink-1.11-SNAPSHOT/conf
2020-06-05 14:38:38,656 INFO  
org.apache.flink.configuration.GlobalConfiguration           [] - Loading 
configuration property: $internal.yarn.log-config-file, 
/home/danrtsey.wy/flink-1.11-SNAPSHOT/conf/log4j.properties
{code}
 

[1]. https://github.com/apache/flink/pull/12501#pullrequestreview-425452351



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to