Thanks for Zhu Zhu's quick response and LGTM now,  +1 (non-binding)

Best
Yun Tang
________________________________
From: Zhu Zhu <reed...@gmail.com>
Sent: Thursday, August 20, 2020 19:39
To: dev <dev@flink.apache.org>; Yun Tang <myas...@live.com>
Subject: Re: [VOTE] Release 1.10.2, release candidate #2

Thanks for pointing it out! @Yun Tang<mailto:myas...@live.com>
The specific release notes of FLINK-18242 was missing.
I have just added the notes for it in the pull request of release notes page
(https://github.com/apache/flink-web/pull/366), as well as the other missing
release notes of FLINK-17800.

Thanks,
Zhu Zhu

Yun Tang <myas...@live.com<mailto:myas...@live.com>> 于2020年8月20日周四 下午7:25写道:
I checked to build from source code and run example on YARN and they all behave 
as expected.
However, I think we should tell user explicitly for the interface changes to 
fix FLINK-18242 and already leave comments for the flink-web PR.


Best
Yun Tang

________________________________
From: Congxian Qiu <qcx978132...@gmail.com<mailto:qcx978132...@gmail.com>>
Sent: Tuesday, August 18, 2020 21:11
To: dev@flink.apache.org<mailto:dev@flink.apache.org> 
<dev@flink.apache.org<mailto:dev@flink.apache.org>>
Subject: Re: [VOTE] Release 1.10.2, release candidate #2

+1 (non-binding)

- checksum & signatures, OK
- build from source, OK
- ran some example jobs on clusters, OK
- all pom files point to 1.10.2
- NOTICE/LICENSE files seem OK

Best,
Congxian


Till Rohrmann <trohrm...@apache.org<mailto:trohrm...@apache.org>> 于2020年8月18日周二 
下午5:24写道:

> +1 (binding)
>
> - verified checksums and signatures
> - verified that dependency changes are reflected in NOTICE/LICENSE files
> - built Flink with Scala 2.12 support from sources
> - Started cluster and ran example jobs, no suspicious log output
>
> Cheers,
> Till
>
> On Mon, Aug 17, 2020 at 4:21 PM Jeff Zhang 
> <zjf...@gmail.com<mailto:zjf...@gmail.com>> wrote:
>
> > +1 (non-binding)
> >
> > Verified it on Zeppelin, it works well.
> >
> >
> >
> > Robert Metzger <rmetz...@apache.org<mailto:rmetz...@apache.org>> 
> > 于2020年8月17日周一 下午9:41写道:
> >
> > > Thanks a lot for creating another release candidate!
> > >
> > > +1 (binding)
> > >
> > > - checked diff:
> > >
> >
> https://github.com/apache/flink/compare/release-1.10.1...release-1.10.2-rc2
> > >   - kubernetes client was upgraded from 4.5.2 to 4.9.2 + some shading
> > > changes ----> verified NOTICE file with shade output
> > > - source compiles
> > > - source sha is correct
> > > - checked staging repository: versions set correctly, contents seem in
> > line
> > > with the changes
> > >
> > >
> > >
> > >
> > > On Mon, Aug 17, 2020 at 1:56 PM Zhu Zhu 
> > > <reed...@gmail.com<mailto:reed...@gmail.com>> wrote:
> > >
> > > > Hi everyone,
> > > >
> > > > Please review and vote on the release candidate #2 for the version
> > > 1.10.2,
> > > > as follows:
> > > > [ ] +1, Approve the release
> > > > [ ] -1, Do not approve the release (please provide specific comments)
> > > >
> > > >
> > > > The complete staging area is available for your review, which
> includes:
> > > > * JIRA release notes [1],
> > > > * the official Apache source release and binary convenience releases
> to
> > > be
> > > > deployed to dist.apache.org<http://dist.apache.org> [2], which are 
> > > > signed with the key with
> > > > fingerprint C63E230EFFF519A5BBF2C9AE6767487CD505859C [3],
> > > > * all artifacts to be deployed to the Maven Central Repository [4],
> > > > * source code tag "release-1.10.2-rc2" [5],
> > > > * website pull request listing the new release and adding
> announcement
> > > blog
> > > > post [6].
> > > >
> > > > The vote will be open for at least 72 hours. It is adopted by
> majority
> > > > approval, with at least 3 PMC affirmative votes.
> > > >
> > > > Thanks,
> > > > Zhu Zhu
> > > >
> > > > [1]
> > > >
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12347791
> > > > [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.10.2-rc2/
> > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > > [4]
> > > >
> > https://repository.apache.org/content/repositories/orgapacheflink-1395/
> > > > [5]
> > > >
> > > >
> > >
> >
> https://github.com/apache/flink/commit/68bb8b612932e479ca03c7ae7c0080818d89c8a1
> > > > [6] https://github.com/apache/flink-web/pull/366
> > > >
> > >
> >
> >
> > --
> > Best Regards
> >
> > Jeff Zhang
> >
>

Reply via email to