+1 (binding) - build from the source and run all tests (successfully) - verified pom files between release-2.1 and release-2.2 branches for any relevant licensing changes
Piotrek pt., 25 wrz 2020 o 10:21 Tzu-Li (Gordon) Tai <tzuli...@apache.org> napisał(a): > +1 (binding) > > - Verified signatures, and no binaries in release artifacts > - Built from source > - Built Docker image from Dockerfiles in > https://github.com/apache/flink-statefun-docker/pull/10. > - Ran E2E tests with the built Dockerfiles (both Java 8 and 11 variants) > - Ran the Python Greeter Example > - Checked the state bootstrapper API > - Ran an AWS deployment: functions running as AWS Lambda functions, > checkpointing to S3 > --- Failure was simulated by 1) restarting TMs and 2) temporarily > forbidding requests by disabling the API Gateway used to expose Lambda > functions > > On Thu, Sep 24, 2020 at 10:20 PM Aljoscha Krettek <aljos...@apache.org> > wrote: > > > +1 (binding) > > > > - built from source > > - built docker image > > - verified Rust SDK works with the 2.2.0 docker image > > > > Aljoscha > > > > On 24.09.20 10:32, Tzu-Li (Gordon) Tai wrote: > > > FYI - the PR for the release announcement has just been drafted: > > > https://github.com/apache/flink-web/pull/379 > > > Any comments there is also highly appreciated! > > > > > > On Thu, Sep 24, 2020 at 5:47 AM Seth Wiesman <sjwies...@gmail.com> > > wrote: > > > > > >> +1 (non binding) > > >> > > >> - Verified signatures and checksums > > >> - Checked licenses and notices > > >> - Clean build from source > > >> - Executed all end to end tests > > >> - Deployed to K8s with Go SDK (no sdk changes required btw :)) > > >> - Simulated TM and remote function failure and verified recovery > > >> - Checked updated docs > > >> > > >> Seth > > >> > > >> On Wed, Sep 23, 2020 at 9:55 AM Igal Shilman <i...@ververica.com> > > wrote: > > >> > > >>> +1 (non binding) > > >>> > > >>> - Verified the signatures and the checksums > > >>> - Built with JDK11 and JDK8 > > >>> - Verified that the source distribution does not contain any binary > > data. > > >>> - Run e2e tests. > > >>> - Run few examples via docker-compose > > >>> - Deployed to Kubernetes with checkpointing to S3, with failure > > >> scenarios: > > >>> -- Killing a TM > > >>> -- Killing a remote function > > >>> -- Killing all the remote functions. > > >>> > > >>> Thanks, > > >>> Igal. > > >>> > > >>> On Wed, Sep 23, 2020 at 10:29 AM Tzu-Li (Gordon) Tai < > > >> tzuli...@apache.org> > > >>> wrote: > > >>> > > >>>> Hi everyone, > > >>>> > > >>>> Please review and vote on the release candidate #2 for the version > > >> 2.2.0 > > >>> of > > >>>> Apache Flink Stateful Functions, > > >>>> as follows: > > >>>> [ ] +1, Approve the release > > >>>> [ ] -1, Do not approve the release (please provide specific > comments) > > >>>> > > >>>> ***Testing Guideline*** > > >>>> > > >>>> You can find here [1] a page in the project wiki on instructions for > > >>>> testing. > > >>>> To cast a vote, it is not necessary to perform all listed checks, > > >>>> but please mention which checks you have performed when voting. > > >>>> > > >>>> ***Release Overview*** > > >>>> > > >>>> As an overview, the release consists of the following: > > >>>> a) Stateful Functions canonical source distribution, to be deployed > to > > >>> the > > >>>> release repository at dist.apache.org > > >>>> b) Stateful Functions Python SDK distributions to be deployed to > PyPI > > >>>> c) Maven artifacts to be deployed to the Maven Central Repository > > >>>> > > >>>> ***Staging Areas to Review*** > > >>>> > > >>>> The staging areas containing the above mentioned artifacts are as > > >>> follows, > > >>>> for your review: > > >>>> * All artifacts for a) and b) can be found in the corresponding dev > > >>>> repository at dist.apache.org [2] > > >>>> * All artifacts for c) can be found at the Apache Nexus Repository > [3] > > >>>> > > >>>> All artifacts are signed with the key > > >>>> 1C1E2394D3194E1944613488F320986D35C33D6A [4] > > >>>> > > >>>> Other links for your review: > > >>>> * JIRA release notes [5] > > >>>> * source code tag "release-2.2.0-rc2" [6] > > >>>> > > >>>> ***Vote Duration*** > > >>>> > > >>>> The only changes since the last RC were the following: > > >>>> > > >>>> - [FLINK-19327][k8s] Bump JobManager heap size to 1 GB: config > > >> change > > >>> in > > >>>> example helm charts (non-blocking) > > >>>> - [FLINK-19329] FunctionGroupOperator#dispose() might throw NPE > > >> during > > >>>> an unclean shutdown (non-blocking, as it doesn't affect recovery > > or > > >>>> execution) > > >>>> - [FLINK-19330][core] Move intialization logic to open() instead > > >>>> initializeState (blocking, but was a very simple fix that was > > >>> thoroughly > > >>>> tested in previous RC). > > >>>> - [hotfix] Fixed out-of-date NOTICE entries caused by Flink > > version > > >>>> upgrade (blocking) > > >>>> > > >>>> Since the changes are fairly minimal and had been tested while > fixing > > >> the > > >>>> previous RC, > > >>>> I'd like to propose a slightly shorter voting period of 48 hours for > > >> this > > >>>> RC. > > >>>> If there are objections for this, please let me know. > > >>>> > > >>>> The voting time will run to at least until 25 Sep., 4pm UTC. > > >>>> It is adopted by majority approval, with at least 3 PMC affirmative > > >>> votes. > > >>>> > > >>>> Thanks, > > >>>> Gordon > > >>>> > > >>>> [1] > > >>>> > > >>>> > > >>> > > >> > > > https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Stateful+Functions+Release > > >>>> [2] > > >>> > https://dist.apache.org/repos/dist/dev/flink/flink-statefun-2.2.0-rc2/ > > >>>> [3] > > >>>> > > >> > https://repository.apache.org/content/repositories/orgapacheflink-1399/ > > >>>> [4] https://dist.apache.org/repos/dist/release/flink/KEYS > > >>>> [5] > > >>>> > > >>>> > > >>> > > >> > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12348350 > > >>>> [6] > > >>>> > > >>>> > > >>> > > >> > > > https://gitbox.apache.org/repos/asf?p=flink-statefun.git;a=commit;h=4420c0382e6ee535daeda2b572ab8eea0af8a614 > > >>>> > > >>> > > >> > > > > > > > >
