Hi Timo, Sorry, I misremembered the deadline for voting and didn't count weekends in. Let's open for the voting until 15th Oct (UTC).
Thank you for the valuable feedback. What about continuing the discussion in the DISUCSS thread? We can start a new vote if the FLIP needs some modifications. Best, Jark On Tue, 13 Oct 2020 at 16:56, Timo Walther <twal...@apache.org> wrote: > Hi Jark, > > as far as I can see it is too early to close the voting process. The > official end time is in roughly 1 hour. > > Also, usually we exclude weekends from the voting period as you can see > here [1] and here [2] to give people more time to respond discussions. > But this is more of an informal process and not mentioned in the bylaws. > > I don't want to block this vote now but here is my feedback for future > contributions: > - I think we should not offer 2 different kinds of syntax that do the > same thing. We should deprecate the old syntax. > - We should have session windows in the new syntax as well to give users > a complete migration path. > - We should investigate if we can remove the additional `FROM > TABLE(...)` syntax. As far as I see it in other examples from Oracle > 18c, the additional `TABLE()` syntax is not necessary anymore for > polymorphic table functions. > > Regards, > Timo > > > [1] > > https://lists.apache.org/thread.html/r0f71d53810c7970430e5952ec69aa59ac54353de6233844421f753d6%40%3Cdev.flink.apache.org%3E > > [2] > > https://lists.apache.org/thread.html/rb1dc7565fdde83063d663e3ff0bbec5e2dbd521247b4dcd28174127f%40%3Cdev.flink.apache.org%3E > > [3] > > https://www.doag.org/formes/pubfiles/11270472/2019-SQL-Andrej_Pashchenko-Polymorphic_Table_Functions_in_18c_Einfuehrung_und_Beispiele-Praesentation.pdf > > > On 13.10.20 08:45, Jark Wu wrote: > > Hi all, > > > > The voting time for FLIP-145 has passed. I'm closing the vote now. > > > > There were 6 +1 votes, 3 of which are binding: > > - Benchao (binding) > > - Jark (binding) > > - Pengcheng Liu > > - Dalong Liu (刘大龙) > > - Hailong Wang > > - Jingsong (binding) > > > > There were no disapproving votes. > > > > Thus, FLIP-145 has been accepted. > > > > Thanks everyone for joining the discussion and giving feedback! > > > > Best, > > Jark > > > > On Mon, 12 Oct 2020 at 12:37, Jingsong Li <jingsongl...@gmail.com> > wrote: > > > >> +1 > >> > >> Best, > >> Jingsong > >> > >> On Sun, Oct 11, 2020 at 8:02 AM hailongwang <18868816...@163.com> > wrote: > >> > >>> +1(non-binding) > >>> > >>> > >>> > >>> Best, > >>> Hailong Wang > >>> At 2020-10-10 17:06:07, "Jark Wu" <imj...@gmail.com> wrote: > >>>> Hi all, > >>>> > >>>> I would like to start the vote for FLIP-145 [1], which is discussed > and > >>>> reached consensus in the discussion thread [2]. > >>>> > >>>> The vote will be open until 13th Oct. (72h), unless there is an > >> objection > >>>> or not enough votes. > >>>> > >>>> Best, > >>>> Jark > >>>> > >>>> [1]: > >>>> > >>> > >> > https://cwiki.apache.org/confluence/display/FLINK/FLIP-145%3A+Support+SQL+windowing+table-valued+function > >>>> [2]: > >>>> > >>> > >> > http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-FLIP-145-Support-SQL-windowing-table-valued-function-td45269.html > >>> > >> > >> > >> -- > >> Best, Jingsong Lee > >> > > > >
