Actually, the check_links.sh script is called in the nightly CI runs https://github.com/apache/flink/blob/master/tools/azure-pipelines/build-apache-repo.yml#L145 --> https://github.com/apache/flink/blob/master/tools/ci/docs.sh#L30+
It was just broken for a while, but fixed by Dian 2 weeks ago. On Wed, Nov 18, 2020 at 6:09 PM Till Rohrmann <trohrm...@apache.org> wrote: > I think automating the check is a good idea since everything which is not > automated will be forgotten at some point. > > Cheers, > Till > > On Wed, Nov 18, 2020 at 12:56 PM Jark Wu <imj...@gmail.com> wrote: > > > +1 for this. Would be better to run the `check_links.sh` for broken > links. > > Btw, could we add the docs build and check into PR CI. > > I think it would be better to guarantee this in the process. > > > > Best, > > Jark > > > > On Wed, 18 Nov 2020 at 18:08, Till Rohrmann <trohrm...@apache.org> > wrote: > > > > > Hi everyone, > > > > > > I noticed in the last couple of days that our docs were broken. The > main > > > reason was invalid links using the {% link %} tag. The best way to > avoid > > > this situation is to build the docs before merging them [1]. That way, > we > > > can ensure that they are not broken. > > > > > > [1] https://github.com/apache/flink/tree/master/docs#build > > > > > > Cheers, > > > Till > > > > > >