+1 (non-binding) Built from source and verified hive connector tests for different hive versions. Setup a cluster to connect to a real hive warehouse and run some queries successfully.
On Thu, Dec 3, 2020 at 8:44 PM Xingbo Huang <hxbks...@gmail.com> wrote: > +1 (non-binding) > > Checks: > 1. verified checksums and signatures > 2. build Flink with Scala 2.11 > 3. pip install pyflink in MacOS/CentOS under py35,py36,py37,py38 > 4. test Pandas UDAF/General UDAF/Python DataStream MapFunction > 5. start standalone cluster and submit a python udf job. > 6. verified NOTICE/LICENSE files of some regular modules > > I observed that the NOTICE file of flink-sql-connector-hbase-2.2 lists 3 > dependencies that are not bundled in: > commons-lang:commons-lang:2.6 > org.apache.hbase:hbase-hadoop-compat:2.2.3 > org.apache.hbase:hbase-hadoop2-compat:2.2.3 > > I guess listing more than dependencies with apache licensed shouldn't be a > blocker issue. I have opened a PR[1] to fix it. > > [1] https://github.com/apache/flink/pull/14299 > > Best, > Xingbo > > Robert Metzger <rmetz...@apache.org> 于2020年12月3日周四 下午5:36写道： > > > There's now a pull request for the announcement blog post, please help > > checking it: https://github.com/apache/flink-web/pull/397 > > > > On Thu, Dec 3, 2020 at 9:03 AM Robert Metzger <rmetz...@apache.org> > wrote: > > > > > +1 (binding) > > > > > > > > > Checks: > > > - checksums seem correct > > > - source archive code compiles > > > - Compiled a test job against the staging repository > > > - launched a standalone cluster, ran some test jobs against it > > > - quickstart contains correct version > > > - regular jars contain correct NOTICE file > > > - Looked a bit over the output of > > > git diff release-1.11.2...release-1.12 -- "**/pom.xml" > > > > > > > > > > > > I noticed that at least one more jar file contains an invalid LICENSE > > file > > > in it's root. This has already been the case with Flink 1.11, and from > > the > > > context (apache flink jar, all the other license and notice files talk > > > about this being an Apache project) it should be clear that the license > > > file is not meant for the whole jar file contents. > > > I will still extend the automated LicenseChecker to resolve this, but I > > > don't want to cancel the release because of this. > > > > > > > > > > > > On Wed, Dec 2, 2020 at 11:19 AM Robert Metzger <rmetz...@apache.org> > > > wrote: > > > > > >> Hi everyone, > > >> > > >> We have resolved the licensing issue Chesnay found. > > >> > > >> Please review and vote on the release candidate #3 for the version > > >> 1.12.0, as follows: > > >> > > >> [ ] +1, Approve the release > > >> [ ] -1, Do not approve the release (please provide specific comments) > > >> > > >> > > >> The complete staging area is available for your review, which > includes: > > >> * JIRA release notes [1a], and website release notes [1b] > > >> * the official Apache source release and binary convenience releases > to > > >> be deployed to dist.apache.org [2], which are signed with the key > with > > >> fingerprint D9839159 [3], > > >> * all artifacts to be deployed to the Maven Central Repository [4], > > >> * source code tag "release-1.12.0-rc3" [5] > > >> > > >> We will soon publish the PR for the release announcement blog post! > > >> > > >> The vote will be open for at least 72 hours. It is adopted by majority > > >> approval, with at least 3 PMC affirmative votes. > > >> > > >> Thanks, > > >> Dian & Robert > > >> > > >> [1a] > > >> > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12348263 > > >> [1b] https://github.com/apache/flink/pull/14195 > > >> [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.12.0-rc3/ > > >> [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > >> [4] > > >> > https://repository.apache.org/content/repositories/orgapacheflink-1404 > > >> [5] https://github.com/apache/flink/releases/tag/release-1.12.0-rc3 > > >> > > >> > > > -- Best regards! Rui Li
