+1 (binding)

- Checked the diff between 1.12.1 and 1.12.2: OK (
https://github.com/apache/flink/compare/release-1.12.1...release-1.12.2-rc1)
  - jackson version has been bumped to 2.10.5.1 through FLINK-21020 and all
NOTICE files updated correctly
  - beanutils version has been bumped to 1.9.4 through FLINK-21123 and all
NOTICE files updated correctly
  - testcontainer version has been bumped to 1.15.1 through FLINK-21277 and
no NOTICE files impact
  - japicmp version has been bumped to 1.12.1 and no NOTICE files impact
- Checked release notes: OK
- Checked sums and signatures: OK
- Maven clean install from source: OK
- Checked the jars in the staging repo: OK
- Checked binary archive: OK
- Approved the website updates (left some notes in PR)

Thanks a lot for putting the RC together!

Best Regards,
Yu


On Sat, 20 Feb 2021 at 12:59, Xintong Song <tonysong...@gmail.com> wrote:

> +1 (non-binding)
>
> - verified checksums & signatures
> - reviewed website PR
> - build from source
> - run example jobs
>   - standalone session & yarn per-job
>   - jobs work as expected
>   - ui & logs look good
>
> Thank you~
>
> Xintong Song
>
>
>
> On Fri, Feb 19, 2021 at 9:59 PM Piotr Nowojski <pnowoj...@apache.org>
> wrote:
>
> > Hi,
> >
> > Thanks for preparing this release candidate.
> >
> > +1 from my side
> >
> > 1. I was monitoring recent builds for Unaligned Checkpoint issues and I
> can
> > confirm that it seems we don't have any failures in the last couple of
> > weeks.
> > 2. There are no tickets with fix version set to 1.12.2. There are two
> > blocker bugs for 1.12.3, but they are still quite far from being merged
> and
> > they shouldn't block the 1.12.2 release, as they have been present in the
> > past release already.
> > 3. I double confirmed that there are no dependency changes between 1.12.1
> > and 1.12.2-RC1, apart of the upgrade of `commons-beanutils` from 1.9.3 to
> > 1.9.4, which had and maintained Apache 2.0 license.
> >
> > Piotrek
> >
> > pt., 19 lut 2021 o 10:24 Yuan Mei <yuanmei.w...@gmail.com> napisaƂ(a):
> >
> > > Hey Roman,
> > >
> > > Thanks for preparing RC1!
> > >
> > > +1 from my side.
> > >
> > > 1. Run-through UnalignedCheckpointITCase for 800+ rounds to make
> > > sure UnalignedCheckpoint is stable
> > > 2. Verified Checksums and GPG Signature
> > > 3. Verified that the source archives do not contain any binaries
> > > 4. Successfully Built the source with Maven, started a local Flink
> > cluster,
> > > and ran the streaming WordCount example with WebMonitor without
> > suspicious
> > > output
> > > 5. Successfully ran the streaming WordCount example with the binary
> > release
> > > as well
> > > 6. Checked for source and binary release to make sure both an Apache
> > > License file and a NOTICE file are included
> > > 7. Manually check all pom file changes since the last release (Flink
> > > 1.12.1); no obvious license problem for me (Need someone to double
> > confirm
> > > this).
> > >
> > > Best
> > > Yuan
> > >
> > > On Wed, Feb 17, 2021 at 3:25 AM Roman Khachatryan <ro...@apache.org>
> > > wrote:
> > >
> > > > Hi everyone,
> > > > Please review and vote on the release candidate #1 for the version
> > > 1.12.2,
> > > > as follows:
> > > > [ ] +1, Approve the release
> > > > [ ] -1, Do not approve the release (please provide specific comments)
> > > >
> > > >
> > > > The complete staging area is available for your review, which
> includes:
> > > > * JIRA release notes [1],
> > > > * the official Apache source release and binary convenience releases
> to
> > > be
> > > > deployed to dist.apache.org [2], which are signed with the key with
> > > > fingerprint 0D545F264D2DFDEBFD4E038F97B4625E2FCF517C [3],
> > > > * all artifacts to be deployed to the Maven Central Repository [4],
> > > > * source code tag "release-1.12.2-rc1" [5],
> > > > * website pull request listing the new release and adding
> announcement
> > > > blog post [6].
> > > >
> > > > The vote will be open for at least 72 hours. It is adopted by
> majority
> > > > approval, with at least 3 PMC affirmative votes.
> > > >
> > > >
> > > > Regards,
> > > > Roman
> > > >
> > > > [1]
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12349502&projectId=12315522
> > > > [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.12.2-rc1/
> > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > > [4]
> > > >
> > https://repository.apache.org/content/repositories/orgapacheflink-1413/
> > > > [5] https://github.com/apache/flink/releases/tag/release-1.12.2-rc1
> > > > [6] https://github.com/apache/flink-web/pull/418
> > > >
> > >
> >
>

Reply via email to