Since FLINK-23233 brings concerns to many guys, and this release candidate #1 had not received enough binding +1 from PMCs, I think we could cancel this RC and wait for that problem resolved.
Best Yun Tang ________________________________ From: Till Rohrmann <trohrm...@apache.org> Sent: Wednesday, July 7, 2021 17:21 To: dev <dev@flink.apache.org> Cc: Xintong Song <tonysong...@gmail.com> Subject: Re: [VOTE] Release 1.13.2, release candidate #1 I think FLINK-23233 sounds like a very serious problem to me. We either continue releasing 1.13.2 and do an immediate 1.13.3 afterwards or we cancel this RC and fix the problem and then resume the 1.13.2 release. Cheers, Till On Wed, Jul 7, 2021 at 5:49 AM JING ZHANG <beyond1...@gmail.com> wrote: > Thanks Xintong for bringing the alarm, +1 on Xintong's proposal to hold the > vote until deciding what to do with FLINK-23233. > > BTW, I made a typo in the previous voting. I mean +1 (non-binding) instead > of +1 (binding). I'm very sorry for the confusion. > > +1 (non-binding). > > 1. Reviewed website pull request > 2. Built from source code flink-1.13.2-src.tgz > < > https://dist.apache.org/repos/dist/dev/flink/flink-1.13.2-rc1/flink-1.13.2-src.tgz > > > succeeded > 3. Started a local Flink cluster, ran the WordCount example, WebUI looks > good, no suspicious output/log > 4. Started cluster and run some e2e sql queries using SQL Client, query > result is expected. > 5. Repeat Step 3 and 4 with flink-1.13.2-bin-scala_2.11.tgz > < > https://dist.apache.org/repos/dist/dev/flink/flink-1.13.2-rc1/flink-1.13.2-bin-scala_2.11.tgz > > > > Best regards, > JING ZHANG > > Xintong Song <tonysong...@gmail.com> 于2021年7月7日周三 上午11:09写道： > > > Hi everyone, > > > > We find a bug that may cause data loss in a rare condition, which IMHO > is a > > release blocker. Please see FLINK-23233 [1] for details. > > > > Given that this bug is not newly introduced but already exists in 1.13.0 > & > > 1.13.1 releases, I would not replace my +1 with a -1 immediately. > Instead, > > I would like to ask the release manager for holding this vote until > > deciding what to do with FLINK-23233. > > > > Thank you~ > > > > Xintong Song > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-23233 > > > > On Wed, Jul 7, 2021 at 12:09 AM JING ZHANG <beyond1...@gmail.com> wrote: > > > > > +1 (binding) > > > > > > 1. Reviewed website pull request > > > 2. Built from source code flink-1.13.2-src.tgz > > > < > > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-1.13.2-rc1/flink-1.13.2-src.tgz > > > > > > > succeeded > > > 3. Started a local Flink cluster, ran the WordCount example, WebUI > looks > > > good, no suspicious output/log > > > 4. Started cluster and run some e2e sql queries using SQL Client, query > > > result is expected. > > > 5. Repeat Step 3 and 4 with flink-1.13.2-bin-scala_2.11.tgz > > > < > > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-1.13.2-rc1/flink-1.13.2-bin-scala_2.11.tgz > > > > > > > > > > Best regards, > > > JING ZHANG > > > > > > > > > Zakelly Lan <zakelly....@gmail.com> 于2021年7月5日周一 下午6:06写道： > > > > > > > +1 (non-binding) > > > > > > > > - built from sources > > > > - run streaming job of wordcount > > > > - web-ui looks good > > > > - checkpoint and restore looks good > > > > > > > > Best, > > > > Zakelly > > > > > > > > On Mon, Jul 5, 2021 at 2:40 PM Jingsong Li <jingsongl...@gmail.com> > > > wrote: > > > > > > > > > +1 (non-binding) > > > > > > > > > > - Verified checksums and signatures > > > > > - Built from sources > > > > > - run table example jobs > > > > > - web-ui looks good > > > > > - sql-client looks good > > > > > > > > > > I think we should update the unresolved JIRAs in [1] to 1.13.3. > > > > > > > > > > And we should check resolved JIRAs in [2], commits of some are not > in > > > the > > > > > 1.13.2. We should exclude them. For example FLINK-23196 FLINK-23166 > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20FLINK%20AND%20fixVersion%20%3D%201.13.2%20AND%20status%20not%20in%20(Closed%2C%20Resolved)%20ORDER%20BY%20updated%20DESC%2C%20priority%20DESC > > > > > [2] > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350218&styleName=&projectId=12315522 > > > > > > > > > > Best, > > > > > Jingsong > > > > > > > > > > On Mon, Jul 5, 2021 at 2:27 PM Xingbo Huang <hxbks...@gmail.com> > > > wrote: > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > - Verified checksums and signatures > > > > > > - Built from sources > > > > > > - Verified Python wheel package contents > > > > > > - Pip install Python wheel package in Mac > > > > > > - Run Python UDF job in Python shell > > > > > > > > > > > > Best, > > > > > > Xingbo > > > > > > > > > > > > Yangze Guo <karma...@gmail.com> 于2021年7月5日周一 上午11:17写道： > > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > > > - built from sources > > > > > > > - run example jobs with standalone and yarn. > > > > > > > - check TaskManager's rest API from the JM master and its > > standby, > > > > > > > everything looks good > > > > > > > > > > > > > > Best, > > > > > > > Yangze Guo > > > > > > > > > > > > > > On Mon, Jul 5, 2021 at 10:10 AM Xintong Song < > > > tonysong...@gmail.com> > > > > > > > wrote: > > > > > > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > > > > > - verified checksums & signatures > > > > > > > > - built from sources > > > > > > > > - run example jobs with standalone and native k8s (with > custom > > > > image) > > > > > > > > deployments > > > > > > > > * job execution looks fine > > > > > > > > * nothing unexpected found in logs and web ui > > > > > > > > > > > > > > > > Thank you~ > > > > > > > > > > > > > > > > Xintong Song > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Sun, Jul 4, 2021 at 12:36 PM JING ZHANG < > > beyond1...@gmail.com > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > Hi yun, > > > > > > > > > Website pull request lists[6] and JIRA release notes[1] > both > > > > > contain > > > > > > > > > unfinished JIRA (such as FLINK-22955). > > > > > > > > > Is it expected? > > > > > > > > > > > > > > > > > > Best regards, > > > > > > > > > JING ZHANG > > > > > > > > > > > > > > > > > > Dawid Wysakowicz <dwysakow...@apache.org> 于2021年7月2日周五 > > > 下午9:05写道： > > > > > > > > > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > > > > > > > > > - verified signatures and checksums > > > > > > > > > > - reviewed the announcement PR > > > > > > > > > > - built from sources and run an example, quickly > checked > > > Web > > > > > UI > > > > > > > > > > - checked diff of pom.xml and NOTICE files from > 1.13.1, > > > > > > > > > > - commons-io updated, > > > > > > > > > > - bundled guava:failureaccess addded in > > > > > > > flink-sql-connector-kinesis > > > > > > > > > > which is properly reflected in the NOTICE file > > > > > > > > > > > > > > > > > > > > Best, > > > > > > > > > > Dawid > > > > > > > > > > On 01/07/2021 12:57, Yun Tang wrote: > > > > > > > > > > > > > > > > > > > > Hi everyone, > > > > > > > > > > Please review and vote on the release candidate #1 for > the > > > > > version > > > > > > > > > 1.13.2, as follows: > > > > > > > > > > [ ] +1, Approve the release > > > > > > > > > > [ ] -1, Do not approve the release (please provide > specific > > > > > > comments) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > The complete staging area is available for your review, > > which > > > > > > > includes: > > > > > > > > > > * JIRA release notes [1], > > > > > > > > > > * the official Apache source release and binary > convenience > > > > > > releases > > > > > > > to > > > > > > > > > be deployed to dist.apache.org [2], which are signed with > > the > > > > key > > > > > > with > > > > > > > > > fingerprint 78A306590F1081CC6794DC7F62DAD618E07CF996 [3], > > > > > > > > > > * all artifacts to be deployed to the Maven Central > > > Repository > > > > > [4], > > > > > > > > > > * source code tag "release-1.13.2-rc1" [5], > > > > > > > > > > * website pull request listing the new release and adding > > > > > > > announcement > > > > > > > > > blog post [6]. > > > > > > > > > > > > > > > > > > > > The vote will be open for at least 72 hours. It is > adopted > > by > > > > > > > majority > > > > > > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > > > > > > > > > > > > > Best, > > > > > > > > > > Yun Tang > > > > > > > > > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350218&styleName=&projectId=12315522 > > > > > > > > > > [2] > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-1.13.2-rc1/ > > > > > > > > > > [3] > https://dist.apache.org/repos/dist/release/flink/KEYS > > > > > > > > > > [4] > > > > > > > > > > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheflink-1429/ > > > > > > > > > > [5] > > > > > > https://github.com/apache/flink/releases/tag/release-1.13.2-rc1 > > > > > > > > > > [6] https://github.com/apache/flink-web/pull/453 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > Best, Jingsong Lee > > > > > > > > > > > > > > >
