Would it be easier to understand if the method would accept a Supplier
instead?
On 20/07/2021 05:36, Becket Qin wrote:
In that case, do we still need the metric here? It seems we are creating a
"global variable" which users may potentially use. I am wondering how much
additional convenience it provides because it seems easy for people to
simply pass the fetch time by themselves if they have decided to not use
SourceReaderBase. Also, it looks like we do not have an API pattern that
lets users get the value of a metric and derive another metric. So I think
it is easier for people to understand if LastFetchTimeGauge() is just an
independent metric by itself, instead of being a part of the
eventTimeFetchLag computation.
