Hi bowen, Thanks for starting this discussion.
I think you can describe your design/implementation in detail. I understand local_ref can help us optimize, but it still needs many details, such as how to reuse function results in codegen. We need a cleaner solution to avoid polluting our CodeGen code. We can discuss it in the JIRA. Best, Jingsong On Thu, Aug 5, 2021 at 6:28 PM Till Rohrmann <trohrm...@apache.org> wrote: > Hi, > > At the moment many community members are busy with finishing their work for > the upcoming feature freeze. This can cause slow responsiveness on the JIRA > tickets. Once the feature freeze is past, people will surely get back to > you. > > Cheers, > Till > > On Mon, Aug 2, 2021 at 8:43 AM 卫博文 <weibowen...@163.com> wrote: > > > Hi, PMC & commiters > > > > > > I have come up with an issue about common subexpression elimination > > https://issues.apache.org/jira/browse/FLINK-23555 > > I hacked on the flink-table-planner module to improve common > subexpression > > elimination by using localRef > > And the result tells that my hacked codes make a big difference. > > The issue has been proposed several days but got little attention. > > Now I don't know how to show you my code hence don't know if it's > suitable. > > I need help and long for your attention. > > > > > > Yours sincerely > -- Best, Jingsong Lee
