Hi everyone, We would like to update WithParams::set(...) to throw an IllegalArgumentException if the given Param instance is not defined on the WithParams instance.
The reason is that there is no use-case where users will want to set a parameter that is not defined on the WithParams instance. And by making this limitation, the save/load implementation could be simpler as it does not need to store the entire Param definition (including validator) which can not be expressed as a json string. Please let us know if you have any suggestions on the proposed changes. Thanks! Dong On Sat, Nov 6, 2021 at 3:35 PM Dong Lin <lindon...@gmail.com> wrote: > Thanks everyone for your votes! > > The proposal has passed with the following votes: > > +1 (Binding): 3 (Jiangjie, Yun, Dian) > +1 (Non-binding): 0 > -1: 0 > > Cheers, > Dong > > > On Sat, Nov 6, 2021 at 9:41 AM Dian Fu <dian0511...@gmail.com> wrote: > >> +1 >> >> On Fri, Nov 5, 2021 at 10:09 PM Yun Gao <yungao...@aliyun.com.invalid> >> wrote: >> >> > +1. >> > >> > Very thanks for drafting the FLIP! >> > >> > >> > Best, >> > Yun >> > >> > >> > ------------------------------------------------------------------ >> > Sender:Becket Qin<becket....@gmail.com> >> > Date:2021/11/05 18:15:11 >> > Recipient:dev<dev@flink.apache.org> >> > Theme:Re: [VOTE] FLIP-174: Improve the WithParam interface >> > >> > +1. Thanks for the writeup, Dong and Zhipeng. >> > >> > Cheers, >> > >> > Jiangjie (Becket) Qin >> > >> > >> > >> > On Fri, Oct 15, 2021 at 2:11 PM Dong Lin <lindon...@gmail.com> wrote: >> > >> > > Hi all, >> > > >> > > We would like to start the vote for FLIP-174: Improve the WithParam >> > > interface [1]. This FLIP was discussed in this thread [2]. >> > > >> > > The goal of this FLIP is to improve the experience of defining, saving >> > and >> > > loading parameters of stages (e.g. Transformer and Estimator) in the >> > Flink >> > > ML repo。 >> > > >> > > The vote will be open for at least 72 hours, following the consensus >> > voting >> > > process. >> > > >> > > Thanks! >> > > Dong Lin and Zhipeng Zhang >> > > >> > > [1] >> > > >> > >> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=181311361 >> > > [2] >> > > >> > > >> > >> https://lists.apache.org/thread.html/re56b61ec0a4a20dadea8f4fe757b8baf94f2eb42b1044e9dd003bf23%40%3Cdev.flink.apache.org%3E >> > > >> > >> > >> >
