Hi Konstantin,
Thanks for your detailed explanation for DynamicPattern[Holder] renaming. I
have another idea for this renaming, what about renaming the Rule to
PatternProcessor? The CEP means that complex event processing, thus the name
PatternProcessor corresponds to the concept of CEP.
A PatternProcessor contains the specific pattern and how to process the
pattern, and this contains the dynamic meaning. What's more, CEP.rule() method
could be renamed to CEP.patternProcess(). WDYT?
Best,
Nicholas Jiang
On 2021/12/14 07:32:46 Konstantin Knauf wrote:
> Hi Nicholas,
>
> I understand that a Rule contains more than the Pattern. Still, I favor
> DynamicPattern[Holder] over Rule, because the term "Rule" does not exist in
> Flink's CEP implementation so far and "dynamic" seems to be the important
> bit here.
>
> Cheers,
>
> Konstantin
>
> On Tue, Dec 14, 2021 at 4:46 AM Nicholas Jiang <nicholasji...@apache.org>
> wrote:
>
> > Hi DianFu,
> >
> > Thanks for your feedback of the FLIP.
> >
> > About the mentioned question for the `getLatestRules`, IMO, this
> > doesn't need to rename into `getRuleChanges` because this method is used
> > for getting the total amount of the latest rules which has been updated
> > once.
> >
> > About the CEP.rule method, the CEP.dynamicPattern renaming is
> > confusing for users. The dynamic pattern only creates the PatternStream not
> > the DataStream. From the concept, a dynamic pattern is also a pattern, not
> > contains the PatternProcessFunction. If renaming the CEP.rule into
> > CEP.dynamicPattern, the return value of the method couldn't include the
> > PatternProcessFunction, only returns the PatternStream. I think the
> > difference between the Rule and the Pattern is that Rule contains the
> > PatternProcessFunction, but the Pattern or DynamicPattern doesn't contain
> > the function.
> >
> > Best
> > Nicholas Jiang
> >
>
>
> --
>
> Konstantin Knauf
>
> https://twitter.com/snntrable
>
> https://github.com/knaufk
>
