I see. A couple of considerations:

1. I would assume FlinkContainerTestEnvironment could be used for more
things than solely connectors, hence it should ideally not be placed into
flink-connector-test-utils

2. If we put it and its dependencies into flink-test-utils, what would be
the purpose of the existence of the flink-end-to-end-tests-common module,
if we then will also have E2E utilities in flink-test-utils? (other than
for segregating stuff that isn't really in a state where we want to share
it )

3. If (1.) is true, it seems that ClusterControllable, TestEnvironment, and
TestEnvironmentSettings are currently misplaced in
flink-connector-test-utils and should be moved together
with FlinkContainerTestEnvironment.

Let me know what you think.

Thanks,
Alexander Fedulov


On Wed, May 25, 2022 at 3:56 PM Chesnay Schepler <ches...@apache.org> wrote:

> I'd be more inclined to move the FlinkContainerTestEnvironment to
> flink-(connector-)test-utils for the time being, because the vast
> majority of stuff in flink-end-to-end-tests-common isn't really in a
> state where we want to share it.
>
> On 25/05/2022 11:55, Alexander Fedulov wrote:
> > Hi everyone,
> >
> > As part of the efforts to externalize the connectors, it became evident
> > that some test utilities that reside in Flink will be required in the
> > external connector repositories. For instance,
> FlinkContainerTestEnvironment
> > and its dependencies reside in the flink-end-to-end-tests-common module
> that
> > is currently not published to Maven (there is only an older version from
> > Cloudera available) [1].
> >
> > I would like to propose to also publish this dependency to Maven. What do
> > you think?
> >
> > [1] https://mvnrepository.com/search?q=flink-end-to-end-tests-common
> >
> > Best,
> > Alexander Fedulov
> >
>
>

Reply via email to