Thanks, Yang. Looks good after your change. +1 for the 48 hour voting time.
On Wed, Jun 1, 2022 at 7:59 AM Gyula Fóra <gyula.f...@gmail.com> wrote: > I agree to create a new RC based on this find. > And 48h voting time seems reasonable as all functional testing will carry > over to this new candidate. > > Gyula > > On Wed, Jun 1, 2022 at 7:56 AM Yang Wang <danrtsey...@gmail.com> wrote: > >> Thanks all for your testing and patience. >> >> And sorry for I have to cancel this VOTE since @Márton Balassi >> <balassi.mar...@gmail.com> found a license issue. We do not list the >> CSS/docs dependencies in the NOTICE file of source release[1]. >> >> I will create another release candidate today including this fix. Given >> that there's no functional changes, we could set the voting period to 48 >> hours for next RC. >> >> >> [1]. >> >> https://dist.apache.org/repos/dist/dev/flink/flink-kubernetes-operator-1.0.0-rc3/ >> >> Best, >> Yang >> >> Jim Busche <jbus...@us.ibm.com> 于2022年6月1日周三 08:30写道： >> >> > Hi Yang, Thank you for RC3 >> > >> > +1 (not-binding) >> > >> > >> > * Podman builds look great with your .dockerignore file and “COPY . >> > .” Thank you for the fix. >> > * Twistlock security scans look clean of both your “ >> > ghcr.io/apache/flink-kubernetes-operator:52b50c2 image” as well as a >> > locally built image from source. >> > * I’ve tried it on both Openshift 4.8 and 4.10 and the basic test >> and >> > UI look good, using helm repo install from the provided helm repo as >> well >> > as from source with the local image. >> > * Logs look normal >> > >> > >> > >> > Thank you, >> > >> > Jim >> > >> > >> > >> >
