Ran Tao created FLINK-27886:
-------------------------------

             Summary: Error way for skipping shade plugin in sub-modules
                 Key: FLINK-27886
                 URL: https://issues.apache.org/jira/browse/FLINK-27886
             Project: Flink
          Issue Type: Improvement
          Components: BuildSystem / Shaded
    Affects Versions: 1.14.4, 1.13.6, 1.15.0
            Reporter: Ran Tao


Currently in some sub-modules, for example, flink-quickstart-java  
flink-quickstart-scala, flink-walkthrough, we want to skip shade but use error 
way like this

{code:java}
<plugin>
                                <groupId>org.apache.maven.plugins</groupId>
                                <artifactId>maven-shade-plugin</artifactId>
                                <executions>
                                        <execution>
                                                </phase>
                                        </execution>
                                </executions>
                        </plugin>
{code}

It just set none phase for itself, can't forbid the inherited parent shade.

the correct way is 

{code:java}
<plugin>
                                <groupId>org.apache.maven.plugins</groupId>
                                <artifactId>maven-shade-plugin</artifactId>
                                <executions>
                                        <execution>
                                                <id>shade-flink</id>
                                                <phase>none</phase>
                                        </execution>
                                </executions>
                        </plugin>
{code}

it can forbid parent shade-flink and also it's own shade. because there is no 
another own shade execution.




--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to