Thanks all for the check. I'm cancelling the RC and will work on fixing the issues
On Thu, Dec 8, 2022 at 10:52 AM Chesnay Schepler <ches...@apache.org> wrote: > Re 2) > > It's bundled under META-INF/versions/15/org/bouncycastle/.. > > > On 07/12/2022 13:54, Danny Cranmer wrote: > > Hey Martijn, > > > > -1 (binding) > > > > Two things I would like to raise: > > 1. Seems like we did not externalise the e2e tests [1]? > > 2. The NOTICE file contains bcpkix-jdk15on/bcprov-ext-jdk15on which I > do > > not believe are bundled. I can see they are test scoped dependencies > > of pulsar-client-all. > > > > - Release notes look correct > > - Verified signatures and hashes > > - No binaries in source > > - Built from source > > - Contents of maven repo look good > > - Tag pushed to github > > - Reviewed web PR > > > > Thanks, > > Danny > > > > [1] > > > https://github.com/apache/flink/tree/master/flink-end-to-end-tests/flink-end-to-end-tests-pulsar > > > > > > On Wed, Nov 30, 2022 at 11:01 AM Martijn Visser < > martijnvis...@apache.org> > > wrote: > > > >> Hi everyone, > >> Please review and vote on the release candidate #1 for the > >> flink-connector-pulsar version v3.0.0, as follows: > >> [ ] +1, Approve the release > >> [ ] -1, Do not approve the release (please provide specific comments) > >> > >> Note: this is equivalent to the Pulsar connector that was released with > >> Flink 1.16. This is the externalized version. > >> > >> The complete staging area is available for your review, which includes: > >> * JIRA release notes [1], > >> * the official Apache source release to be deployed to dist.apache.org > >> [2], > >> which are signed with the key with fingerprint > >> A5F3BCE4CBE993573EC5966A65321B8382B219AF [3], > >> * all artifacts to be deployed to the Maven Central Repository [4], > >> * source code tag v3.0.0-rc1 [5], > >> * website pull request listing the new release [6]. > >> > >> The vote will be open for at least 72 hours. It is adopted by majority > >> approval, with at least 3 PMC affirmative votes. > >> > >> Thanks, > >> Martijn > >> > >> https://twitter.com/MartijnVisser82 > >> https://github.com/MartijnVisser > >> > >> [1] > >> > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352588 > >> [2] > >> > >> > https://dist.apache.org/repos/dist/dev/flink/flink-connector-pulsar-3.0.0-rc1/ > >> [3] https://dist.apache.org/repos/dist/release/flink/KEYS > >> [4] > >> https://repository.apache.org/content/repositories/orgapacheflink-1553/ > >> [5] > >> > https://github.com/apache/flink-connector-pulsar/releases/tag/v3.0.0-rc1 > >> [6] https://github.com/apache/flink-web/pull/589 > >> > >
