+1 (binding)
- clean source release
- builds from source
- source matches git tag
- all expected maven artifacts present
- maven artifacts have correct Flink version suffix
- releases notes are good
- PR is good
Not a blocking issue, but the source NOTICE currently says "Apache
Flink", where it should say "Apache Flink
AWS connector" or something.
On 07/12/2022 14:38, Teoh, Hong wrote:
+1 (non-binding)
* Hashes and Signatures look good
* All required files on dist.apache.org
* Tag is present in Github
* Verified source archive does not contain any binary files
* Source archive builds using maven
* Started packaged example SQL job using SQL client. Verified that the
following connectors work:
* flink-sql-connector-aws-kinesis-firehose
* flink-sql-connector-aws-kinesis-streams
* flink-sql-connector-kinesis
Cheers,
Hong
On 06/12/2022, 17:41, "Danny Cranmer" <[email protected]> wrote:
CAUTION: This email originated from outside of the organization. Do not
click links or open attachments unless you can confirm the sender and know the
content is safe.
Hi everyone,
I am reopening this vote since the issue we detected [1] cannot be fixed
without AWS SDK changes, and it is an existing issue, not a regression.
Please review and vote on the release candidate #1 for the version 4.0.0,
as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)
This release externalizes the Kinesis Data Streams and Kinesis Data
Firehose connector to the flink-connector-aws repository.
The complete staging area is available for your review, which includes:
* JIRA release notes [2],
* the official Apache source release to be deployed to dist.apache.org [3],
which are signed with the key with fingerprint 125FD8DB [4],
* all artifacts to be deployed to the Maven Central Repository [5],
* source code tag v4.0.0-rc1 [6],
* website pull request listing the new release [7].
The vote will be open for at least 72 hours (Friday 9th December 18:00
UTC). It is adopted by majority approval, with at least 3 PMC affirmative
votes.
Thanks,
Danny
[1] https://issues.apache.org/jira/browse/FLINK-30304
[2]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352538
[3]
https://dist.apache.org/repos/dist/dev/flink/flink-connector-aws-4.0.0-rc1/
[4] https://dist.apache.org/repos/dist/release/flink/KEYS
[5] https://repository.apache.org/content/repositories/orgapacheflink-1558/
[6] https://github.com/apache/flink-connector-aws/releases/tag/v4.0.0-rc1
[6] https://github.com/apache/flink-web/pull/592
On Mon, Dec 5, 2022 at 4:17 PM Danny Cranmer <[email protected]>
wrote:
> This release is officially cancelled due to the discovery of a critical
> bug [1].
>
> I will fix and follow up with an RC.
>
> [1] https://issues.apache.org/jira/browse/FLINK-30304
>
> On Mon, Dec 5, 2022 at 3:25 PM Danny Cranmer <[email protected]>
> wrote:
>
>> Hi everyone,
>> Please review and vote on the release candidate #1 for the version
4.0.0,
>> as follows:
>> [ ] +1, Approve the release
>> [ ] -1, Do not approve the release (please provide specific comments)
>>
>> This release externalizes the Kinesis Data Streams and Kinesis Data
>> Firehose connector to the flink-connector-aws repository.
>>
>> The complete staging area is available for your review, which includes:
>> * JIRA release notes [1],
>> * the official Apache source release to be deployed to dist.apache.org
>> [2], which are signed with the key with fingerprint 125FD8DB [3],
>> * all artifacts to be deployed to the Maven Central Repository [4],
>> * source code tag v4.0.0-rc1 [5],
>> * website pull request listing the new release [6].
>>
>> The vote will be open for at least 72 hours (Thursday 8th December 16:00
>> UTC). It is adopted by majority approval, with at least 3 PMC
affirmative
>> votes.
>>
>> Thanks,
>> Danny
>>
>> [1]
>>
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352538
>> [2]
>>
https://dist.apache.org/repos/dist/dev/flink/flink-connector-aws-4.0.0-rc1/
>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>> [4]
>> https://repository.apache.org/content/repositories/orgapacheflink-1558/
>> [5]
https://github.com/apache/flink-connector-aws/releases/tag/v4.0.0-rc1
>> [6] https://github.com/apache/flink-web/pull/592
>>
>>
>>
