+1 (binding) * Checked hash and signature * Build from source and run tests * Checked licenses
On Mon, Dec 19, 2022 at 1:50 PM Maximilian Michels <m...@apache.org> wrote: > +1 (binding) > > Release looks good. > > 1. Downloaded the source archive release staged at > > https://dist.apache.org/repos/dist/dev/flink/flink-connector-opensearch-1.0.0-rc1/ > 2. Verified the signature > 3. Inspect extracted source code for binaries > 4. Compiled the source code > 5. Verified license files / headers > > -Max > > On Mon, Dec 19, 2022 at 11:16 AM Sergey Nuyanzin <snuyan...@gmail.com> > wrote: > > > +1 (non-binding) > > > > - Validated hashes and signature > > - Verified that no binaries exist in the source archive > > - Build from sources with Maven > > - Verified licenses > > > > On Sat, Dec 17, 2022 at 8:34 AM Martijn Visser <martijnvis...@apache.org > > > > wrote: > > > > > Hi Danny, > > > > > > +1 (binding) > > > > > > - Validated hashes > > > - Verified signature > > > - Verified that no binaries exist in the source archive > > > - Build the source with Maven > > > - Verified licenses > > > - Verified web PRs > > > > > > Thanks for the help! > > > > > > Best regards, Martijn > > > > > > On Fri, Dec 16, 2022 at 5:37 PM Danny Cranmer <dannycran...@apache.org > > > > > wrote: > > > > > > > Apologies I messed up the link to "the official Apache source release > > to > > > be > > > > deployed to dist.apache.org" [1] > > > > > > > > Thanks, > > > > Danny > > > > > > > > [1] > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-connector-opensearch-1.0.0-rc1 > > > > > > > > On Fri, Dec 16, 2022 at 2:04 PM Ahmed Hamdy <hamdy10...@gmail.com> > > > wrote: > > > > > > > > > Thank you Danny, > > > > > > > > > > +1 (non-binding) > > > > > > > > > > * Hashes and Signatures look good > > > > > * Tag is present in Github > > > > > * Verified source archive does not contain any binary files > > > > > * Source archive builds using maven > > > > > * Verified Notice and Licence files > > > > > > > > > > On Fri, 16 Dec 2022 at 12:41, Danny Cranmer < > dannycran...@apache.org > > > > > > > > wrote: > > > > > > > > > > > Hi everyone, > > > > > > Please review and vote on the release candidate #1 for the > version > > > > 1.0.0, > > > > > > as follows: > > > > > > [ ] +1, Approve the release > > > > > > [ ] -1, Do not approve the release (please provide specific > > comments) > > > > > > > > > > > > > > > > > > The complete staging area is available for your review, which > > > includes: > > > > > > * JIRA release notes [1], > > > > > > * the official Apache source release to be deployed to > > > dist.apache.org > > > > > > [2], > > > > > > which are signed with the key with fingerprint 125FD8DB [3], > > > > > > * all artifacts to be deployed to the Maven Central Repository > [4], > > > > > > * source code tag v1.0.0-rc1 [5], > > > > > > * website pull request listing the new release [6]. > > > > > > * pull request to integrate opensearch docs into the Flink docs > > [7]. > > > > > > > > > > > > The vote will be open for at least 72 hours excluding weekends > > > > (Wednesday > > > > > > 21st December 13:00 UTC). It is adopted by majority approval, > with > > at > > > > > least > > > > > > 3 PMC affirmative votes. > > > > > > > > > > > > Thanks, > > > > > > Danny > > > > > > > > > > > > [1] > > https://issues.apache.org/jira/projects/FLINK/versions/12352293 > > > > > > [2] > https://dist.apache.org/repos/dist/dev/flink/flink-connector- > > > > > > <connector>-${NEW_VERSION}-rc${RC_NUM} > > > > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > > > > [4] > > > > > > > https://repository.apache.org/content/repositories/orgapacheflink-1569 > > > > > > [5] > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/flink-connector-opensearch/releases/tag/v1.0.0-rc1 > > > > > > [6] https://github.com/apache/flink-web/pull/596 > > > > > > [7] https://github.com/apache/flink/pull/21518 > > > > > > > > > > > > > > > > > > > > > > > > -- > > Best regards, > > Sergey > > >
