lincoln lee created FLINK-30897: ----------------------------------- Summary: Avoid timeouts in JUnit tests Key: FLINK-30897 URL: https://issues.apache.org/jira/browse/FLINK-30897 Project: Flink Issue Type: Improvement Components: Tests Reporter: lincoln lee
As our [testing guideline|https://flink.apache.org/contributing/code-style-and-quality-common.html#avoid-timeouts-in-junit-tests] says we should 'Avoid timeouts in JUnit tests' but rather depend on the global timeout in Azure. There're 10 itcases throughout the project that use the 'Timeout Rule' to set local timeouts. We need to check if we can change this dependency one by one List of related test classes: {code} flink-end-to-end-tests-common-kafka (1 usage found) org.apache.flink.tests.util.kafka (1 usage found) SQLClientSchemaRegistryITCase.java (1 usage found) 78 @ClassRule public static final Timeout TIMEOUT = new Timeout(10, TimeUnit.MINUTES); flink-glue-schema-registry-avro-test_2.12 (1 usage found) org.apache.flink.glue.schema.registry.test (1 usage found) GlueSchemaRegistryAvroKinesisITCase.java (1 usage found) 74 @ClassRule public static final Timeout TIMEOUT = new Timeout(10, TimeUnit.MINUTES); flink-glue-schema-registry-json-test (1 usage found) org.apache.flink.glue.schema.registry.test.json (1 usage found) GlueSchemaRegistryJsonKinesisITCase.java (1 usage found) 68 @ClassRule public static final Timeout TIMEOUT = new Timeout(10, TimeUnit.MINUTES); flink-runtime (1 usage found) org.apache.flink.runtime.io.disk (1 usage found) BatchShuffleReadBufferPoolTest.java (1 usage found) 41 @Rule public Timeout timeout = new Timeout(60, TimeUnit.SECONDS); flink-streaming-java (1 usage found) org.apache.flink.streaming.api.operators.async (1 usage found) AsyncWaitOperatorTest.java (1 usage found) 117 @Rule public Timeout timeoutRule = new Timeout(100, TimeUnit.SECONDS); flink-tests (5 usages found) org.apache.flink.runtime.operators.lifecycle (3 usages found) BoundedSourceITCase.java (1 usage found) 75 @Rule public Timeout timeoutRule = new Timeout(10, TimeUnit.MINUTES); PartiallyFinishedSourcesITCase.java (1 usage found) 79 @Rule public Timeout timeoutRule = new Timeout(10, TimeUnit.MINUTES); StopWithSavepointITCase.java (1 usage found) 103 @Rule public Timeout timeoutRule = new Timeout(10, TimeUnit.MINUTES); org.apache.flink.test.runtime (2 usages found) JoinDeadlockITCase.java (1 usage found) 39 @Rule public Timeout globalTimeout = new Timeout(120 * 1000); // Set timeout for deadlocks SelfJoinDeadlockITCase.java (1 usage found) 46 @Rule public Timeout globalTimeout = new Timeout(120 * 1000); // Set timeout for deadlocks {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)