Thanks for the update, Dong! +1 for the new table option.
Best, Qingsheng On Mon, Feb 6, 2023 at 2:39 PM Dong Lin <lindon...@gmail.com> wrote: > As I am reviewing the FLIP-208 PR here > <https://github.com/apache/flink/pull/>, I realized that a new public API > change was added to the Proposed Change section in this > <https://github.com/apache/flink/pull/> modification after this voting > thread starts, without being mentioned in this thread. > > I have moved this change to the Public Interface section now. The change is > that "a new connector option 'scan.record.evaluator.class' will be added to > provide the custom RecordEvaluator class". > > Since this change is relatively minor and looks good to me, I will re-use > this voting thread to confirm this change is OK. > > Qingsheng and Leonard: can you help check whether this public interface > change looks good to you? > > I will keep this discussion open for at least 72 hours before merging the > PR. > > Thanks, > Dong > > > On Tue, Dec 27, 2022 at 3:29 PM Leonard Xu <xbjt...@gmail.com> wrote: > > > +1 (binding) > > > > Best, > > Leonard > > > > > > > On Dec 26, 2022, at 4:22 PM, Qingsheng Ren <renqs...@gmail.com> wrote: > > > > > > +1 (binding) > > > > > > Best, > > > Qingsheng > > > Ververica (Alibaba) > > > > > > On Wed, Dec 21, 2022 at 3:13 PM Dong Lin <lindon...@gmail.com> wrote: > > > > > >> Hi all, > > >> > > >> We would like to start the vote for FLIP-208: Add RecordEvaluator to > > >> dynamically stop source based on de-serialized records [1]. This FLIP > > was > > >> discussed in this thread [2]. > > >> > > >> This feature is needed by users who currently depend on > > >> KafkaDeserializationSchema::isEndOfStream() to migrate their Flink job > > from > > >> FlinkKafkaConsumer to KafkaSource. And we won't be able to > > >> remove FlinkKafkaConsumer and FlinkKafkaProducer before adding this > > >> feature. > > >> > > >> Thanks, > > >> Dong > > >> > > >> [1] > > >> > > >> > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-208%3A+Add+RecordEvaluator+to+dynamically+stop+source+based+on+de-serialized+records > > >> [2] https://lists.apache.org/thread/z87m68ggzkx0s427tmrllswm4l1g7owc > > >> > > > > >
